Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md |
| diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md |
| index 4908ec22f11a85c3006a454dcff23273312a63a9..6773666fe2059fc1c92e74486641dfc1752c025e 100644 |
| --- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md |
| +++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md |
| @@ -21,7 +21,7 @@ object should keep alive. |
| ``DECLARE_VIRTUAL_TRACE_WRAPPERS()``. |
| 5. Define the method using ``DEFINE_TRACE_WRAPPERS(ClassName)``. |
| 6. Trace all fields that received a wrapper tracing type in (1) and (2) using |
| -``visitor->traceWrapers(<m_field>)`` in the body of ``DEFINE_TRACE_WRAPPERS``. |
| +``visitor->TraceWrappers(<m_field>)`` in the body of ``DEFINE_TRACE_WRAPPERS``. |
|
Michael Lippautz
2017/04/19 08:49:12
Oh boy :)
Thanks, we could also do this in a sepa
|
| The following example illustrates these steps: |
| @@ -42,8 +42,8 @@ class SomeDOMObject : public ScriptWrappable { // (1) |
| }; |
| DEFINE_TRACE_WRAPPERS(SomeDOMObject) { // (5) |
| - visitor->traceWrappers(m_otherWrappable); // (6) |
| - visitor->traceWrappers(m_v8object); // (6) |
| + visitor->TraceWrappers(m_otherWrappable); // (6) |
| + visitor->TraceWrappers(m_v8object); // (6) |
| } |
| ``` |
| @@ -82,7 +82,6 @@ Pick the header file depending on what types are needed. |
| ```c++ |
| #include "bindings/core/v8/ScriptWrappable.h" |
| -#include "bindings/core/v8/TraceWrapperBase.h" |
| #include "bindings/core/v8/TraceWrapperMember.h" |
| #include "bindings/core/v8/TraceWrapperV8Reference.h" |
| ``` |
| @@ -126,7 +125,7 @@ class SomeDOMObject : public ScriptWrappable { |
| }; |
| DEFINE_TRACE_WRAPPERS(SomeDOMObject) { |
| - visitor->traceWrappers(m_otherWrappable); |
| + visitor->TraceWrappers(m_otherWrappable); |
| } |
| ``` |
| @@ -159,7 +158,7 @@ class SomeDOMObject : public ScriptWrappable { |
| }; |
| DEFINE_TRACE_WRAPPERS(SomeDOMObject) { |
| - visitor->traceWrappers(m_otherWrappable); |
| + visitor->TraceWrappers(m_otherWrappable); |
| } |
| ``` |
| @@ -185,7 +184,7 @@ class SomeDOMObject : public ScriptWrappable { |
| DEFINE_TRACE_WRAPPERS(SomeDOMObject) { |
| for (auto other : m_otherWrappables) |
| - visitor->traceWrappers(other); |
| + visitor->TraceWrappers(other); |
| } |
| ``` |
| @@ -226,7 +225,7 @@ class SomeDOMObject : public ScriptWrappable { |
| DEFINE_TRACE_WRAPPERS(SomeDOMObject) { |
| for (auto other : m_otherWrappables) |
| - visitor->traceWrappers(other); |
| + visitor->TraceWrappers(other); |
| } |
| ``` |