third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp - Issue 2828643002: Make customElements.define faster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

Issue 2828643002: Make customElements.define faster

Patch Set: Remove some unneeded casts. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

index c406a9af3f0795498d709df755e90735b145b0a5..c5c593ce98f53628053b87c7eba0c68f31463b90 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

@@ -24,11 +24,11 @@ CustomElementDefinition::CustomElementDefinition(

CustomElementDefinition::CustomElementDefinition(

const CustomElementDescriptor& descriptor,

- const HashSet<AtomicString>& observed_attributes)

+ HashSet<AtomicString>&& observed_attributes)

: descriptor_(descriptor),

observed_attributes_(observed_attributes),

has_style_attribute_changed_callback_(

- observed_attributes.Contains(HTMLNames::styleAttr.LocalName())) {}

+ observed_attributes_.Contains(HTMLNames::styleAttr.LocalName())) {}

CustomElementDefinition::~CustomElementDefinition() {}