Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h

Issue 2828643002: Make customElements.define faster
Patch Set: Remove some unneeded casts. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h
index 09b111e11ffbecf09a77e9e8005cd0375f7ef64b..a854bafe4464925c87b6c35e6e1b098c54b91f51 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h
@@ -8,7 +8,9 @@
#include "base/gtest_prod_util.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptWrappable.h"
+#include "bindings/core/v8/TraceWrapperMember.h"
#include "core/CoreExport.h"
+#include "core/dom/custom/CustomElementDefinition.h"
#include "platform/heap/Handle.h"
#include "platform/wtf/Noncopyable.h"
#include "platform/wtf/text/AtomicString.h"
@@ -16,7 +18,6 @@
namespace blink {
-class CustomElementDefinition;
class CustomElementDefinitionBuilder;
class CustomElementDescriptor;
class Element;
@@ -53,6 +54,7 @@ class CORE_EXPORT CustomElementRegistry final
ScriptValue get(const AtomicString& name);
bool NameIsDefined(const AtomicString& name) const;
CustomElementDefinition* DefinitionForName(const AtomicString& name) const;
+ CustomElementDefinition* DefinitionForId(CustomElementDefinition::Id) const;
kochi 2017/04/28 06:24:16 Make this private.
// TODO(dominicc): Switch most callers of definitionForName to
// definitionFor when implementing type extensions.
@@ -83,9 +85,12 @@ class CORE_EXPORT CustomElementRegistry final
class ElementDefinitionIsRunning;
bool element_definition_is_running_;
- using DefinitionMap =
- HeapHashMap<AtomicString, Member<CustomElementDefinition>>;
- DefinitionMap definitions_;
+ using DefinitionList =
+ HeapVector<TraceWrapperMember<CustomElementDefinition>>;
+ DefinitionList definitions_;
+
+ using DefinitionMap = HashMap<AtomicString, size_t>;
+ DefinitionMap nameIdMap_;
kochi 2017/04/28 06:24:16 s/nameIdMap_/name_id_map_/
Member<const LocalDOMWindow> owner_;

Powered by Google App Engine
This is Rietveld 408576698