chromeos: converts DragImageViewTest to AshTestBase

chromeos: converts DragImageViewTest to AshTestBase

And removes usage of WmWindow.

BUG=707057, 687656
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2828543003
Cr-Commit-Position: refs/heads/master@{#465393}
Committed: https://chromium.googlesource.com/chromium/src/+/f14333c9889b233634b98673489f1268ea722034

[sky, 2017-04-18 21:25:05]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 21:25:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-04-18 21:43:09]

lgtm with a nit and an aside q.

https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base.h
File ash/test/ash_test_base.h (right):

https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base....
ash/test/ash_test_base.h:100: // TODO(sky): convert existing CreateTestWindow()
functions into this one.
aside q: Will returning a unique_ptr instead of a raw pointer change the window
destruction semantics for the numerous tests calling the existing functions?
(generally I think of tests simply allowing the window to be destroyed later on
via some TearDown mechanism, not via aura::Window destruction in the test
fixture body when the unique_ptr goes out of scope). I imagine this generally
won't be a problem, and a few cases can release the unique_ptr, but I'm just
curious about your thoughts.

https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base....
ash/test/ash_test_base.h:101: std::unique_ptr<aura::Window> CreateTestWindow(
optional nit: order params to match CreateTestWindowInShellWithDelegateAndType;
that might ease some conversion later on.

[commit-bot: I haz the power, 2017-04-18 21:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 21:54:19]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-18 22:03:03]

https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base.h
File ash/test/ash_test_base.h (right):

https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base....
ash/test/ash_test_base.h:100: // TODO(sky): convert existing CreateTestWindow()
functions into this one.
On 2017/04/18 21:43:09, msw wrote:
> aside q: Will returning a unique_ptr instead of a raw pointer change the
window
> destruction semantics for the numerous tests calling the existing functions?
> (generally I think of tests simply allowing the window to be destroyed later
on
> via some TearDown mechanism, not via aura::Window destruction in the test
> fixture body when the unique_ptr goes out of scope). I imagine this generally
> won't be a problem, and a few cases can release the unique_ptr, but I'm just
> curious about your thoughts.

I actually haven't done a big analysis. I generally favor unique_ptr, event if
the callers do a release() as it's less error prone.

https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base....
ash/test/ash_test_base.h:101: std::unique_ptr<aura::Window> CreateTestWindow(
On 2017/04/18 21:43:09, msw wrote:
> optional nit: order params to match
CreateTestWindowInShellWithDelegateAndType;
> that might ease some conversion later on.

I went with this ordering based on looking at tests and seeing most wanting to
specify bounds, and then falling off in usage from there.

[sky, 2017-04-18 22:03:08]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-04-18 22:03:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 22:21:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492552988790240,
"parent_rev": "7a884812c144c57d1853361d431629f5c90006fe", "commit_rev":
"f14333c9889b233634b98673489f1268ea722034"}

[commit-bot: I haz the power, 2017-04-18 22:21:20]

Description was changed from

==========
chromeos: converts DragImageViewTest to AshTestBase

And removes usage of WmWindow.

BUG=707057,687656
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
chromeos: converts DragImageViewTest to AshTestBase

And removes usage of WmWindow.

BUG=707057,687656
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2828543003
Cr-Commit-Position: refs/heads/master@{#465393}
Committed:
https://chromium.googlesource.com/chromium/src/+/f14333c9889b233634b98673489f...
==========

[commit-bot: I haz the power, 2017-04-18 22:21:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f14333c9889b233634b98673489f...