Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2828543003: chromeos: converts DragImageViewTest to AshTestBase (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: converts DragImageViewTest to AshTestBase And removes usage of WmWindow. BUG=707057, 687656 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2828543003 Cr-Commit-Position: refs/heads/master@{#465393} Committed: https://chromium.googlesource.com/chromium/src/+/f14333c9889b233634b98673489f1268ea722034

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -26 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_image_view.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_image_view.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M ash/drag_drop/drag_image_view_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M ash/test/ash_test_base.h View 2 chunks +12 lines, -0 lines 4 comments Download
M ash/test/ash_test_base.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
3 years, 8 months ago (2017-04-18 21:24:55 UTC) #1
msw
lgtm with a nit and an aside q. https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base.h File ash/test/ash_test_base.h (right): https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base.h#newcode100 ash/test/ash_test_base.h:100: // ...
3 years, 8 months ago (2017-04-18 21:43:09 UTC) #4
sky
https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base.h File ash/test/ash_test_base.h (right): https://codereview.chromium.org/2828543003/diff/20001/ash/test/ash_test_base.h#newcode100 ash/test/ash_test_base.h:100: // TODO(sky): convert existing CreateTestWindow() functions into this one. ...
3 years, 8 months ago (2017-04-18 22:03:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828543003/20001
3 years, 8 months ago (2017-04-18 22:03:50 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 22:21:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f14333c9889b233634b98673489f...

Powered by Google App Engine
This is Rietveld 408576698