Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: net/quic/core/quic_flags_list.h

Issue 2828523003: Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled position because it neve… (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/congestion_control/bbr_sender_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file intentionally does not have header guards, it's included 5 // This file intentionally does not have header guards, it's included
6 // inside a macro to generate values. 6 // inside a macro to generate values.
7 7
8 // This file contains the list of QUIC protocol flags. 8 // This file contains the list of QUIC protocol flags.
9 9
10 // If true, QUIC BBR congestion control may be enabled via Finch and/or via QUIC 10 // If true, QUIC BBR congestion control may be enabled via Finch and/or via QUIC
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 153
154 // If true, multipath bit is not used in public flag. 154 // If true, multipath bit is not used in public flag.
155 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_remove_multipath_bit, false) 155 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_remove_multipath_bit, false)
156 156
157 // Allow QUIC's flow control autotuning to increase the window as 157 // Allow QUIC's flow control autotuning to increase the window as
158 // quickly for the first adjustment as in subsequent ones. 158 // quickly for the first adjustment as in subsequent ones.
159 QUIC_FLAG(bool, 159 QUIC_FLAG(bool,
160 FLAGS_quic_reloadable_flag_quic_flow_control_faster_autotune, 160 FLAGS_quic_reloadable_flag_quic_flow_control_faster_autotune,
161 true) 161 true)
162 162
163 // Only consider using the ack spacing in QUIC BBR if 2 packets are acked at
164 // once.
165 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2, false)
166
167 // If true, QUIC BBR stores a max filtered number of bytes delivered at a rate 163 // If true, QUIC BBR stores a max filtered number of bytes delivered at a rate
168 // faster than the sending rate. 164 // faster than the sending rate.
169 QUIC_FLAG(bool, 165 QUIC_FLAG(bool,
170 FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes, 166 FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes,
171 false) 167 false)
172 168
173 // If true, allow cubic updates on every ack, rather than occasionally limiting 169 // If true, allow cubic updates on every ack, rather than occasionally limiting
174 // the frequency to once every 30ms. 170 // the frequency to once every 30ms.
175 QUIC_FLAG(bool, 171 QUIC_FLAG(bool,
176 FLAGS_quic_reloadable_flag_quic_enable_cubic_per_ack_updates, 172 FLAGS_quic_reloadable_flag_quic_enable_cubic_per_ack_updates,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_adaptive_time_loss, false) 206 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_adaptive_time_loss, false)
211 207
212 // In QUIC BBR, keep sending at the max bandwidth observed in the previous 2 208 // In QUIC BBR, keep sending at the max bandwidth observed in the previous 2
213 // RTTs for another SRTT. 209 // RTTs for another SRTT.
214 QUIC_FLAG(bool, 210 QUIC_FLAG(bool,
215 FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate, 211 FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate,
216 false) 212 false)
217 213
218 // Base CWND on SRTT instead of min_rtt for QUIC BBR. 214 // Base CWND on SRTT instead of min_rtt for QUIC BBR.
219 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_base_cwnd_on_srtt, false) 215 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_base_cwnd_on_srtt, false)
OLDNEW
« no previous file with comments | « net/quic/core/congestion_control/bbr_sender_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698