Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2828503004: Include video frame memory held by the compositor in memory reports. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Include video frame memory held by the compositor in memory reports. This provides an estimate for the amount of memory owned by the video frame held by the compositor after the video renderer has suspended. In this case, there is 1 frame of video memory held by VideoFrameCompositor while the pipeline reports zero memory since the renderer has been destroyed. This doesn't resolve the linked bug, but does improve the accuracy of the reported value with high resolution video. BUG=700776 TEST=none Review-Url: https://codereview.chromium.org/2828503004 Cr-Commit-Position: refs/heads/master@{#465435} Committed: https://chromium.googlesource.com/chromium/src/+/ecc7661918e467da103b9e8f1c05b83265b1e707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M media/blink/webmediaplayer_impl.cc View 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
DaleCurtis
3 years, 8 months ago (2017-04-18 21:42:59 UTC) #2
sandersd (OOO until July 31)
lgtm
3 years, 8 months ago (2017-04-18 21:47:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828503004/1
3 years, 8 months ago (2017-04-18 22:01:22 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 00:31:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ecc7661918e467da103b9e8f1c05...

Powered by Google App Engine
This is Rietveld 408576698