Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2828443004: Update readyForTesting var even on Oobe.initialize() failure. (Closed)

Created:
3 years, 8 months ago by hidehiko
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Update readyForTesting var even on Oobe.initialize() failure. |readyForTesting| was introduced to let callers know whether the DOM loading is done so testing APIs accessing DOM can be successfully called. Although, in some cases Oobe.initialize() is failed, so it timed out. Instead, this CL sets the value always. Then, callers can be notified even on failure cases, so they can avoid timeout. BUG=710975 TEST=Ran bots. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825453002 Cr-Commit-Position: refs/heads/master@{#465126} (cherry picked from commit 341333dfb5561bc987995a3cfe05aefc3ecb17e7) Review-Url: https://codereview.chromium.org/2828443004 . Cr-Commit-Position: refs/branch-heads/3071@{#46} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f04994956c70496a087fb184d815b5d40bc0daf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/login/login_shared.js View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hidehiko
3 years, 8 months ago (2017-04-19 06:22:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f04994956c70496a087fb184d815b5d40bc0daf6.

Powered by Google App Engine
This is Rietveld 408576698