Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 282843003: Reland https://codereview.chromium.org/276493002: Enable ToolsSanityTest.SingleElementDeletedWithBr… (Closed)

Created:
6 years, 7 months ago by Alexander Potapenko
Modified:
6 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Reland https://codereview.chromium.org/276493002: Enable ToolsSanityTest.SingleElementDeletedWithBraces and ToolsSanityTest.ArrayDeletedWithoutBraces under AddressSanitizer on Linux. Also make sure the tests aren't disabled under non-ASan on OSX. BUG=172614 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M base/tools_sanity_unittest.cc View 3 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
TBR
6 years, 7 months ago (2014-05-14 08:28:46 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-14 09:25:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/282843003/1
6 years, 7 months ago (2014-05-14 09:25:39 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 10:55:38 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 11:50:38 UTC) #5
Message was sent while issue was closed.
Change committed as 270383

Powered by Google App Engine
This is Rietveld 408576698