Enable ToolsSanityTest.SingleElementDeletedWithBraces and ToolsSanityTest.ArrayDeletedWithoutBraces…

Enable ToolsSanityTest.SingleElementDeletedWithBraces and ToolsSanityTest.ArrayDeletedWithoutBraces under AddressSanitizer on Linux.
Make the tests free the memory to avoid leak reports from LSan.

BUG=172614
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270087

[Alexander Potapenko, 2014-05-12 10:34:11]

PTAL

[Nico, 2014-05-13 08:12:47]

mac bots still look sad

[Alexander Potapenko, 2014-05-13 08:57:05]

On 2014/05/13 08:12:47, Nico (traveling this week) wrote:
> mac bots still look sad

That's because I forgot to add DISABLED under the OS_MACOSX ifdef. Fixed.

[Alexander Potapenko, 2014-05-13 10:55:17]

On 2014/05/13 08:57:05, Alexander Potapenko wrote:
> On 2014/05/13 08:12:47, Nico (traveling this week) wrote:
> > mac bots still look sad
> 
> That's because I forgot to add DISABLED under the OS_MACOSX ifdef. Fixed.

base_unittests pass on all ASan bots now.

[Nico, 2014-05-13 11:27:26]

lgtm, thanks!

https://codereview.chromium.org/276493002/diff/60001/base/tools_sanity_unitte...
File base/tools_sanity_unittest.cc (right):

https://codereview.chromium.org/276493002/diff/60001/base/tools_sanity_unitte...
base/tools_sanity_unittest.cc:150: // Under ASan the crash happens in the child
process, need to free the memory
Which child process? The one spawned by the dead test? If so, reword the
comment. ("…in the child process spawned by HARMFULL_ACCESS…")?

https://codereview.chromium.org/276493002/diff/60001/base/tools_sanity_unitte...
base/tools_sanity_unittest.cc:152: delete[] foo;
nit: I think we usually format this as `delete [] foo` in chromium (space after
delete)

[Alexander Potapenko, 2014-05-13 11:37:36]

https://codereview.chromium.org/276493002/diff/60001/base/tools_sanity_unitte...
File base/tools_sanity_unittest.cc (right):

https://codereview.chromium.org/276493002/diff/60001/base/tools_sanity_unitte...
base/tools_sanity_unittest.cc:150: // Under ASan the crash happens in the child
process, need to free the memory
On 2014/05/13 11:27:26, Nico (traveling this week) wrote:
> Which child process? The one spawned by the dead test? If so, reword the
> comment. ("…in the child process spawned by HARMFULL_ACCESS…")?

Done.

https://codereview.chromium.org/276493002/diff/60001/base/tools_sanity_unitte...
base/tools_sanity_unittest.cc:152: delete[] foo;
On 2014/05/13 11:27:26, Nico (traveling this week) wrote:
> nit: I think we usually format this as `delete [] foo` in chromium (space
after
> delete)

A quick codesearch gives 669 "delete["s vs. 507 "delete ["s, but the latter one
is more consistent with the rest of the file.

[Alexander Potapenko, 2014-05-13 11:38:08]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-05-13 11:39:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/276493002/80001

[commit-bot: I haz the power, 2014-05-13 13:34:22]

Change committed as 270087