Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2828413002: MD Settings: Polish string for disabling internal PDF plugin (Closed)

Created:
3 years, 8 months ago by tommycli
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Polish string for disabling internal PDF plugin Updates string to one provided by srahim@ which better reflects the actual behavior. BUG=700118 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2828413002 Cr-Commit-Position: refs/heads/master@{#466138} Committed: https://chromium.googlesource.com/chromium/src/+/4158d8311733c2901331f74b1c73dd026f740672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/pdf_documents.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tommycli
dbeam: PTAL. Screenshot in bug.
3 years, 8 months ago (2017-04-20 19:11:12 UTC) #5
Dan Beam
lgtm
3 years, 8 months ago (2017-04-20 21:16:54 UTC) #8
tommycli
On 2017/04/20 21:16:54, Dan Beam wrote: > lgtm thanks!
3 years, 8 months ago (2017-04-20 21:17:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828413002/1
3 years, 8 months ago (2017-04-20 21:18:24 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 21:24:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4158d8311733c2901331f74b1c73...

Powered by Google App Engine
This is Rietveld 408576698