When collecting traces for native allocation, we depend on the architecture the native code is runn…

When collecting traces for native allocation, we depend on the architecture the native code is running, not the Dart code.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/dca21921fb50fc43c30697d5e6c40048e59800c0

[rmacnak, 2017-04-20 17:47:35]

rmacnak@google.com changed reviewers:
+ bkonyi@google.com, zra@google.com

[rmacnak, 2017-04-20 17:47:37]

https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
File runtime/vm/malloc_hooks_tcmalloc.cc (right):

https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
runtime/vm/malloc_hooks_tcmalloc.cc:141: ASSERT((sample_ == NULL) ||
Profiler can fail if we can't get a good fp or stack bounds.

[zra, 2017-04-20 18:09:18]

lgtm

[bkonyi, 2017-04-20 18:10:30]

https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
File runtime/vm/malloc_hooks_arm64.cc (left):

https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
runtime/vm/malloc_hooks_arm64.cc:14: const intptr_t kSkipCount = 6;
Is there any reason this was removed? Have you tried running the tests on arm64
debug?

[rmacnak, 2017-04-20 21:14:20]

On 2017/04/20 18:10:30, bkonyi wrote:
>
https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
> File runtime/vm/malloc_hooks_arm64.cc (left):
> 
>
https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
> runtime/vm/malloc_hooks_arm64.cc:14: const intptr_t kSkipCount = 6;
> Is there any reason this was removed? Have you tried running the tests on
arm64
> debug?

Yes, this the value to get the right traces on my Dragonboard.

[bkonyi, 2017-04-20 21:57:19]

On 2017/04/20 21:14:20, rmacnak wrote:
> On 2017/04/20 18:10:30, bkonyi wrote:
> >
>
https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
> > File runtime/vm/malloc_hooks_arm64.cc (left):
> > 
> >
>
https://codereview.chromium.org/2828383002/diff/20001/runtime/vm/malloc_hooks...
> > runtime/vm/malloc_hooks_arm64.cc:14: const intptr_t kSkipCount = 6;
> > Is there any reason this was removed? Have you tried running the tests on
> arm64
> > debug?
> 
> Yes, this the value to get the right traces on my Dragonboard.

I figured, but just wanted to make sure!

[rmacnak, 2017-04-21 20:34:56]

Description was changed from

==========
When collecting traces for native allocation, we depend on the architecture the
native code is running, not the Dart code.
==========

to

==========
When collecting traces for native allocation, we depend on the architecture the
native code is running, not the Dart code.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dca21921fb50fc43c30697d5e6c40048e59800c0
==========

[rmacnak, 2017-04-21 20:34:57]

Committed patchset #2 (id:20001) manually as
dca21921fb50fc43c30697d5e6c40048e59800c0 (presubmit successful).