runtime/vm/malloc_hooks_arm64.cc - Issue 2828383002: When collecting traces for native allocation, we depend on the architecture the native code is runn…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/malloc_hooks_arm64.cc

Issue 2828383002: When collecting traces for native allocation, we depend on the architecture the native code is runn… (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/malloc_hooks_arm64.cc

diff --git a/runtime/vm/malloc_hooks_arm64.cc b/runtime/vm/malloc_hooks_arm64.cc

index 53f2970ce90f04e27974a4aab25c7ef12fec6f31..e50ea0b24c3fcc4f73e00110ef7067469c02e034 100644

--- a/runtime/vm/malloc_hooks_arm64.cc

+++ b/runtime/vm/malloc_hooks_arm64.cc

@@ -6,16 +6,12 @@

#include "vm/globals.h"

-#if defined(TARGET_ARCH_ARM64)

+#if defined(HOST_ARCH_ARM64)

namespace dart {

-#if defined(DEBUG)

-const intptr_t kSkipCount = 6;

bkonyi 2017/04/20 18:10:30 Is there any reason this was removed? Have you tri

-#elif !(defined(PRODUCT) || defined(DEBUG))

const intptr_t kSkipCount = 5;

-#endif

} // namespace dart

-#endif // defined(TARGET_ARCH_ARM64)

+#endif // defined(HOST_ARCH_ARM64)