Convert constructor/audiobuffer.html to use new Audit

Convert constructor/audiobuffer.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/audiobuffer.html

Review-Url: https://codereview.chromium.org/2828363002
Cr-Commit-Position: refs/heads/master@{#466490}
Committed: https://chromium.googlesource.com/chromium/src/+/d5a456422acfcbcfd11be8d01cd3defdcdea9f7f

[Raymond Toy, 2017-04-21 15:59:44]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-21 15:59:44]

PTAL

[hongchan, 2017-04-21 20:52:39]

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html
(right):

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:14: var
context;
var -> let

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:78:
'buffer1 = new AudioBuffer({numberOfChannels: 3, length: 1, sampleRate: 48000}')
Is this clang-formatted?

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:211:
.beEqualToArray(data);
Return the return value of the assertion here.

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:218:
.then(() => {
(returnValues => {
  should(returnValues[1] && returnValues{2})....
});

[Raymond Toy, 2017-04-21 21:02:05]

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html
(right):

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:14: var
context;
On 2017/04/21 20:52:39, hongchan wrote:
> var -> let

Done.

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:78:
'buffer1 = new AudioBuffer({numberOfChannels: 3, length: 1, sampleRate: 48000}')
On 2017/04/21 20:52:38, hongchan wrote:
> Is this clang-formatted?

It was, and I ran it again. No change here.

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:211:
.beEqualToArray(data);
On 2017/04/21 20:52:38, hongchan wrote:
> Return the return value of the assertion here.

Done.

https://codereview.chromium.org/2828363002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:218:
.then(() => {
On 2017/04/21 20:52:39, hongchan wrote:
> (returnValues => {
>   should(returnValues[1] && returnValues{2})....
> });

Done.

[hongchan, 2017-04-21 21:38:29]

lgtm with nits

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html
(right):

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:79:
'buffer1 = new AudioBuffer({numberOfChannels: 3, length: 1, sampleRate: 48000}')
Yeah, this is a long string, so clang-format has no idea where to break. Should
we consider to wrap this at 80 by hand?

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:196: 
Two empty lines.

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:207: let
c2Success = false;
Then we don't need cXSuccess any more.

[Raymond Toy, 2017-04-21 21:55:12]

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html
(right):

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:79:
'buffer1 = new AudioBuffer({numberOfChannels: 3, length: 1, sampleRate: 48000}')
On 2017/04/21 21:38:28, hongchan wrote:
> Yeah, this is a long string, so clang-format has no idea where to break.
Should
> we consider to wrap this at 80 by hand?

Done.

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:196: 
On 2017/04/21 21:38:28, hongchan wrote:
> Two empty lines.

Done.

https://codereview.chromium.org/2828363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html:207: let
c2Success = false;
On 2017/04/21 21:38:29, hongchan wrote:
> Then we don't need cXSuccess any more.

Done.

[Raymond Toy, 2017-04-21 21:55:20]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-21 21:55:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2828363002/#ps80001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-04-21 21:55:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:35:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492811720885640,
"parent_rev": "c8abe8c3b07d77195777e07180a4122f4d50246a", "commit_rev":
"d5a456422acfcbcfd11be8d01cd3defdcdea9f7f"}

[commit-bot: I haz the power, 2017-04-21 23:35:36]

Description was changed from

==========
Convert constructor/audiobuffer.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/audiobuffer.html
==========

to

==========
Convert constructor/audiobuffer.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/audiobuffer.html

Review-Url: https://codereview.chromium.org/2828363002
Cr-Commit-Position: refs/heads/master@{#466490}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5a456422acfcbcfd11be8d01cd3...
==========

[commit-bot: I haz the power, 2017-04-21 23:35:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d5a456422acfcbcfd11be8d01cd3...