Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2828333003: supersize: Strip linker-added prefixes from symbol names (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Strip linker-added prefixes from symbol names Rather than entirely lose this information though, store the prefix within symbol.flags as a bitfield. BUG=681694 Review-Url: https://codereview.chromium.org/2828333003 Cr-Commit-Position: refs/heads/master@{#466096} Committed: https://chromium.googlesource.com/chromium/src/+/fdad51f24bced15b7cab495106b3e2152ced8dbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -180 lines) Patch
M tools/binary_size/libsupersize/archive.py View 3 chunks +25 lines, -1 line 0 comments Download
M tools/binary_size/libsupersize/describe.py View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/file_format.py View 3 chunks +9 lines, -5 lines 0 comments Download
M tools/binary_size/libsupersize/models.py View 7 chunks +38 lines, -13 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/ActualDiff.golden View 1 chunk +49 lines, -49 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive.golden View 1 chunk +36 lines, -36 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 4 chunks +19 lines, -19 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 4 chunks +19 lines, -19 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden View 4 chunks +33 lines, -33 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/test.map View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/04/20 17:39:01, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🚧
3 years, 8 months ago (2017-04-20 17:39:12 UTC) #3
estevenson
lgtm
3 years, 8 months ago (2017-04-20 19:03:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828333003/1
3 years, 8 months ago (2017-04-20 19:34:38 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 19:51:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdad51f24bced15b7cab495106b3...

Powered by Google App Engine
This is Rietveld 408576698