Add top level type inference logic for integer literals.

Add top level type inference logic for integer literals.

This CL hooks up enough infrastructure for doing simple top level type
inference of variables whose initializer is an int.

Additional type inference rules will be added in follow-up CLs.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/77d26a330cd535ed90f2f53aa0da134a4deb95f1

[Paul Berry, 2017-04-20 12:49:25]

paulberry@google.com changed reviewers:
+ ahe@google.com

[Paul Berry, 2017-04-21 07:02:05]

paulberry@google.com changed reviewers:
+ karlklose@chromium.org

[Paul Berry, 2017-04-21 09:01:28]

paulberry@google.com changed reviewers:
+ johnniwinther@google.com

[karlklose, 2017-04-21 11:11:01]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-04-21 11:11:02]

LGTM

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:95: /// If not `null`,
dependencies on fields are accumulated into this list.
Maybe add a short comment on when this is `null`.

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:70: /// Gets the
declared type of the given [field], or `nul` if the type is
'nul' -> 'null'.

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:144: }
Add an TODO to do type-checking.

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:192: ///
Determines if the given [field] has completed top level type inference
Rephrase it as 'Determines if top level type inference has been completed for
[field].'?

[Paul Berry, 2017-04-21 11:32:26]

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:95: /// If not `null`,
dependencies on fields are accumulated into this list.
On 2017/04/21 11:11:01, karlklose wrote:
> Maybe add a short comment on when this is `null`.

Done.

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:70: /// Gets the
declared type of the given [field], or `nul` if the type is
On 2017/04/21 11:11:01, karlklose wrote:
> 'nul' -> 'null'.

Done.

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:144: }
On 2017/04/21 11:11:01, karlklose wrote:
> Add an TODO to do type-checking.

Done.  (Actually the comment belongs in inferField)

https://codereview.chromium.org/2828253003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:192: ///
Determines if the given [field] has completed top level type inference
On 2017/04/21 11:11:01, karlklose wrote:
> Rephrase it as 'Determines if top level type inference has been completed for
> [field].'?

Done.

[Paul Berry, 2017-04-21 11:38:23]

Description was changed from

==========
Add top level type inference logic for integer literals.

This CL hooks up enough infrastructure for doing simple top level type
inference of variables whose initializer is an int.

Additional type inference rules will be added in follow-up CLs.
==========

to

==========
Add top level type inference logic for integer literals.

This CL hooks up enough infrastructure for doing simple top level type
inference of variables whose initializer is an int.

Additional type inference rules will be added in follow-up CLs.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/77d26a330cd535ed90f2f53aa0da134a4deb95f1
==========

[Paul Berry, 2017-04-21 11:38:25]

Committed patchset #2 (id:20001) manually as
77d26a330cd535ed90f2f53aa0da134a4deb95f1 (presubmit successful).