Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart

Issue 2828253003: Add top level type inference logic for integer literals. (Closed)
Patch Set: Clean up, bug fix, and remove unintentional expectations changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
index 62c03a6fed6470329bcbf353c48bab5533b1aa95..d0bf021010c845bada6dd29cb9c1976a4eee5c45 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
@@ -4,6 +4,8 @@
library fasta.kernel_enum_builder;
+import 'package:front_end/src/fasta/builder/ast_factory.dart' show AstFactory;
+
import 'package:kernel/ast.dart'
show
Arguments,
@@ -87,6 +89,7 @@ class KernelEnumBuilder extends SourceClassBuilder
null, charOffset, cls);
factory KernelEnumBuilder(
+ AstFactory astFactory,
List<MetadataBuilder> metadata,
String name,
List<Object> constantNamesAndOffsets,
@@ -121,7 +124,15 @@ class KernelEnumBuilder extends SourceClassBuilder
/// String toString() => { 0: ‘E.id0’, . . ., n-1: ‘E.idn-1’}[index]
/// }
members["index"] = new KernelFieldBuilder(
- null, intType, "index", finalMask, parent, charOffset);
+ astFactory,
+ parent.loader.topLevelTypeInferrer,
+ null,
+ intType,
+ "index",
+ finalMask,
+ parent,
+ charOffset,
+ null);
KernelConstructorBuilder constructorBuilder = new KernelConstructorBuilder(
null,
constMask,
@@ -140,7 +151,15 @@ class KernelEnumBuilder extends SourceClassBuilder
int index = 0;
List<MapEntry> toStringEntries = <MapEntry>[];
KernelFieldBuilder valuesBuilder = new KernelFieldBuilder(
- null, listType, "values", constMask | staticMask, parent, charOffset);
+ astFactory,
+ parent.loader.topLevelTypeInferrer,
+ null,
+ listType,
+ "values",
+ constMask | staticMask,
+ parent,
+ charOffset,
+ null);
members["values"] = valuesBuilder;
KernelProcedureBuilder toStringBuilder = new KernelProcedureBuilder(
null,
@@ -165,7 +184,15 @@ class KernelEnumBuilder extends SourceClassBuilder
continue;
}
KernelFieldBuilder fieldBuilder = new KernelFieldBuilder(
- null, selfType, name, constMask | staticMask, parent, charOffset);
+ astFactory,
+ parent.loader.topLevelTypeInferrer,
+ null,
+ selfType,
+ name,
+ constMask | staticMask,
+ parent,
+ charOffset,
+ null);
members[name] = fieldBuilder;
toStringEntries.add(new MapEntry(
new IntLiteral(index), new StringLiteral("$className.$name")));

Powered by Google App Engine
This is Rietveld 408576698