Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2828233002: DCHECK that audio devices are stopped prior to destruction. (Closed)

Created:
3 years, 8 months ago by Max Morin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DCHECK that audio devices are stopped prior to destruction. This is required (and documented by a comment in the header file), so the DCHECKs are motivated. BUG=711400 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2828233002 Cr-Commit-Position: refs/heads/master@{#466898} Committed: https://chromium.googlesource.com/chromium/src/+/63575c0e1d7b89a2658f34a07a6bb7ba3a3d1e97

Patch Set 1 #

Patch Set 2 : Fix bad test. #

Patch Set 3 : More DCHECKs! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M media/audio/audio_input_device.cc View 1 2 1 chunk +11 lines, -1 line 0 comments Download
M media/audio/audio_input_device_unittest.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M media/audio/audio_output_device.cc View 1 2 1 chunk +11 lines, -1 line 0 comments Download
M media/audio/audio_output_device_unittest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (22 generated)
Max Morin
Henrik: As I don't have the hardware, could you try running the offending tests and ...
3 years, 8 months ago (2017-04-20 10:41:12 UTC) #9
Max Morin
Added some more DCHECKs in PS3.
3 years, 8 months ago (2017-04-24 09:27:45 UTC) #16
Henrik Grunell
I've run browser_tests locally with filter=*WebRtc*, no dchecks hit. I couldn't run Chrome due to ...
3 years, 8 months ago (2017-04-24 15:16:21 UTC) #19
Henrik Grunell
lgtm
3 years, 8 months ago (2017-04-24 15:18:35 UTC) #20
Max Morin
Dale: PTAL. I'll watch the webrtc bots closely when landing this (running them prior to ...
3 years, 8 months ago (2017-04-24 16:31:30 UTC) #22
DaleCurtis
media/ lgtm
3 years, 8 months ago (2017-04-24 19:37:26 UTC) #25
Max Morin
Thanks, both of you.
3 years, 8 months ago (2017-04-25 06:19:57 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828233002/60001
3 years, 8 months ago (2017-04-25 06:20:21 UTC) #28
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 06:24:50 UTC) #31
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/63575c0e1d7b89a2658f34a07a6b...

Powered by Google App Engine
This is Rietveld 408576698