Mojo: cancel pending AsyncWait calls when the callers thread exits

Mojo: cancel pending AsyncWait calls when the callers thread exits

This should resolve some memory leak issues.

BUG=372487
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270639

[darin (slow to review), 2014-05-13 20:44:20]

OK, this is ready for review.

[darin (slow to review), 2014-05-13 20:45:27]

+trung -- please review my choice of synthetic MojoResult value. Thanks!

[sky, 2014-05-13 21:22:41]

LGTM

https://codereview.chromium.org/282823003/diff/60001/mojo/common/handle_watch...
File mojo/common/handle_watcher.cc (right):

https://codereview.chromium.org/282823003/diff/60001/mojo/common/handle_watch...
mojo/common/handle_watcher.cc:263: explicit State(HandleWatcher* watcher,
nit: no explicit

https://codereview.chromium.org/282823003/diff/60001/mojo/common/handle_watch...
mojo/common/handle_watcher.cc:305: };
nit: DISALLOW_...

https://codereview.chromium.org/282823003/diff/60001/mojo/common/handle_watch...
File mojo/common/handle_watcher_unittest.cc (right):

https://codereview.chromium.org/282823003/diff/60001/mojo/common/handle_watch...
mojo/common/handle_watcher_unittest.cc:23: void ObserveCallback(bool*
was_signaled, MojoResult* result_observed,
nit: one param per line when you wrap.

https://codereview.chromium.org/282823003/diff/60001/mojo/common/handle_watch...
mojo/common/handle_watcher_unittest.cc:326: MojoResult result;
nit: initialize this to something.

[viettrungluu, 2014-05-13 21:48:48]

On 2014/05/13 20:45:27, darin wrote:
> +trung -- please review my choice of synthetic MojoResult value. Thanks!

LGTM for that.

[darin (slow to review), 2014-05-13 21:53:50]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-13 22:05:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/282823003/100001

[commit-bot: I haz the power, 2014-05-14 01:41:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-14 01:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 01:47:07]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[darin (slow to review), 2014-05-14 23:37:01]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-14 23:37:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/282823003/120001

[darin (slow to review), 2014-05-15 03:33:36]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-15 03:35:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/282823003/140001

[darin (slow to review), 2014-05-15 05:37:58]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-15 05:39:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/282823003/160001

[commit-bot: I haz the power, 2014-05-15 07:27:10]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-05-15 08:30:58]

Change committed as 270639