Mojo: cancel pending AsyncWait calls when the callers thread exits

mojo/common/handle_watcher_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/common/handle_watcher.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "base/test/simple_test_tick_clock.h"
 #include "mojo/common/time_helper.h"
 #include "mojo/public/cpp/environment/environment.h"
 #include "mojo/public/cpp/system/core.h"
 #include "mojo/public/cpp/test_support/test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace mojo {
 namespace common {
 namespace test {
 
+void ObserveCallback(bool* was_signaled, MojoResult* result_observed,

[sky, 2014/05/13 21:22:42]

nit: one param per line when you wrap.

+                     MojoResult result) {
+  *was_signaled = true;
+  *result_observed = result;
+}
+
 void RunUntilIdle() {
   base::RunLoop run_loop;
   run_loop.RunUntilIdle();
 }
 
 void DeleteWatcherAndForwardResult(
     HandleWatcher* watcher,
     base::Callback<void(MojoResult)> next_callback,
     MojoResult result) {
   delete watcher;
@@ skipping 275 matching lines @@
   callback_helper.StartWithCallback(watcher, test_pipe.handle1.get(),
                                     base::Bind(&DeleteWatcherAndForwardResult,
                                                watcher,
                                                callback_helper.GetCallback()));
   EXPECT_TRUE(mojo::test::WriteTextMessage(test_pipe.handle0.get(),
                                            std::string()));
   callback_helper.RunUntilGotCallback();
   EXPECT_TRUE(callback_helper.got_callback());
 }
 
+TEST(HandleWatcherCleanEnvironmentTest, AbortedOnMessageLoopDestruction) {
+  bool was_signaled = false;
+  MojoResult result;

[sky, 2014/05/13 21:22:42]

nit: initialize this to something.

+
+  Environment env;
+
+  MessagePipe pipe;
+  HandleWatcher watcher;
+  {
+    base::MessageLoop loop;
+
+    watcher.Start(pipe.handle0.get(),
+                  MOJO_WAIT_FLAG_READABLE,
+                  MOJO_DEADLINE_INDEFINITE,
+                  base::Bind(&ObserveCallback, &was_signaled, &result));
+
+    // Now, let the MessageLoop get torn down. We expect our callback to run.
+  }
+
+  EXPECT_TRUE(was_signaled);
+  EXPECT_EQ(MOJO_RESULT_ABORTED, result);
+}
+
 }  // namespace test
 }  // namespace common
 }  // namespace mojo