Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2828183002: Manual revert of "Convert the overlay scrollbar flag to use FeatureList" (Closed)

Created:
3 years, 8 months ago by aboxhall
Modified:
3 years, 8 months ago
Reviewers:
bokan, chaopeng, dtapuska
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, vakh+watch_chromium.org, piman+watch_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, nasko+codewatch_chromium.org, jam, timvolodine, mathp+autofillwatch_chromium.org, blink-reviews, darin-cc_chromium.org, asvitkine+watch_chromium.org, grt+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual revert of "Convert the overlay scrollbar flag to use FeatureList" https://codereview.chromium.org/2827183003/ Seems to have caused many test failures on Linux TSan: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/4485/steps/content_browsertests TBR=chaopeng,bokan,dtapuska NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2828183002 Cr-Commit-Position: refs/heads/master@{#465893} Committed: https://chromium.googlesource.com/chromium/src/+/5a560fe4e50c4532a181a24f26bdb6f572344a63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -88 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_classifier_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_startup_flags.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/native_theme/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/native_theme/native_theme_features.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/native_theme/native_theme_features.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A + ui/native_theme/native_theme_switches.h View 2 chunks +7 lines, -7 lines 0 comments Download
A ui/native_theme/native_theme_switches.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828183002/1
3 years, 8 months ago (2017-04-20 03:54:31 UTC) #2
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 03:55:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a560fe4e50c4532a181a24f26bd...

Powered by Google App Engine
This is Rietveld 408576698