Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2828163002: Add assert descriptions to fontfaceset-check-platform-fonts.html (Closed)

Created:
3 years, 8 months ago by Kunihiko Sakamoto
Modified:
3 years, 8 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add assert descriptions to fontfaceset-check-platform-fonts.html This test is flaky on windows but test log contains no information about which assertion has failed. This CL adds description strings to the assertions to try to understand the cause of the flakiness. BUG=713094 Review-Url: https://codereview.chromium.org/2828163002 Cr-Commit-Position: refs/heads/master@{#465931} Committed: https://chromium.googlesource.com/chromium/src/+/9aba1eec4dc75e527670d747c38c68d7b1fa96c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/fontfaceset-check-platform-fonts.html View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Kunihiko Sakamoto
3 years, 8 months ago (2017-04-20 04:48:31 UTC) #4
Takashi Toyoshima
lgtm
3 years, 8 months ago (2017-04-20 05:46:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828163002/1
3 years, 8 months ago (2017-04-20 05:51:35 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 07:05:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9aba1eec4dc75e527670d747c38c...

Powered by Google App Engine
This is Rietveld 408576698