Show autofill sync status in CBD

Show autofill sync status in CBD

This changes the AutofillCounter to indicate that autofill data is synced.

BUG=681523
Review-Url: https://codereview.chromium.org/2828083003
Cr-Commit-Position: refs/heads/master@{#468606}
Committed: https://chromium.googlesource.com/chromium/src/+/ae41773373496eaa692beb85a20cade679127d58

[dullweber, 2017-04-20 15:30:51]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 15:31:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 16:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:23:26]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-04-21 11:35:50]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 11:36:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 12:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 12:19:13]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dullweber, 2017-04-25 14:18:30]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 14:18:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-04-25 14:29:57]

Description was changed from

==========
Show autofill sync status in CBD

BUG=681523
==========

to

==========
Show autofill sync status in CBD

This changes the AutofillCounter to indicate that autofill data is synced.

BUG=681523
==========

[commit-bot: I haz the power, 2017-04-25 15:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:06:37]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-04-27 14:56:11]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 14:56:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 16:03:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:03:49]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-04-28 10:52:49]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 10:53:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 11:28:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 11:28:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dullweber, 2017-04-28 12:39:43]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 12:40:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-04-28 12:57:14]

dullweber@chromium.org changed reviewers:
+ msramek@chromium.org

[dullweber, 2017-04-28 12:57:15]

Hi Martin,
here is another cl for indicating "(synced)". This time for autofill.

[commit-bot: I haz the power, 2017-04-28 14:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:22:57]

Dry run: This issue passed the CQ dry run.

[msramek, 2017-04-28 19:13:13]

browsing_data/ LGTM

https://codereview.chromium.org/2828083003/diff/100001/chrome/browser/browsin...
File chrome/browser/browsing_data/autofill_counter_browsertest.cc (right):

https://codereview.chromium.org/2828083003/diff/100001/chrome/browser/browsin...
chrome/browser/browsing_data/autofill_counter_browsertest.cc:159: bool
CountingFinishedSinceLastAsked() {
This is starting to look like we'll need BrowsingDataCounterTestBase. Can you
add a TODO or file a bug?

https://codereview.chromium.org/2828083003/diff/100001/components/browsing_da...
File components/browsing_data/core/counters/autofill_counter.cc (right):

https://codereview.chromium.org/2828083003/diff/100001/components/browsing_da...
components/browsing_data/core/counters/autofill_counter.cc:188: void
AutofillCounter::OnStateChanged(syncer::SyncService* sync) {
Ditto here. We may be able to start moving things to the base class; perhaps we
should add a pref name -> sync datatype convertor to the utils, and then unify
the logic here?

(not in this CL, of course)

[dullweber, 2017-05-02 08:22:19]

On 2017/04/28 19:13:13, msramek (slow) wrote:
> browsing_data/ LGTM
> 
>
https://codereview.chromium.org/2828083003/diff/100001/chrome/browser/browsin...
> File chrome/browser/browsing_data/autofill_counter_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2828083003/diff/100001/chrome/browser/browsin...
> chrome/browser/browsing_data/autofill_counter_browsertest.cc:159: bool
> CountingFinishedSinceLastAsked() {
> This is starting to look like we'll need BrowsingDataCounterTestBase. Can you
> add a TODO or file a bug?
> 
>
https://codereview.chromium.org/2828083003/diff/100001/components/browsing_da...
> File components/browsing_data/core/counters/autofill_counter.cc (right):
> 
>
https://codereview.chromium.org/2828083003/diff/100001/components/browsing_da...
> components/browsing_data/core/counters/autofill_counter.cc:188: void
> AutofillCounter::OnStateChanged(syncer::SyncService* sync) {
> Ditto here. We may be able to start moving things to the base class; perhaps
we
> should add a pref name -> sync datatype convertor to the utils, and then unify
> the logic here?
> 
> (not in this CL, of course)

Thanks for the review. I filed a bug for this: http://crbug.com/717443

[dullweber, 2017-05-02 10:43:32]

dullweber@chromium.org changed reviewers:
+ droger@chromium.org

[dullweber, 2017-05-02 10:43:33]

droger@chromium.org: Please review changes in 
ios/chrome/browser/browsing_data/ios_browsing_data_counter_factory.cc

[droger, 2017-05-02 11:33:13]

lgtm

[dullweber, 2017-05-02 11:43:24]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-05-02 11:43:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 12:28:52]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493725404759140,
"parent_rev": "172ca56fe77575d9be332eaecd4c958fc07d5c3c", "commit_rev":
"ae41773373496eaa692beb85a20cade679127d58"}

[commit-bot: I haz the power, 2017-05-02 12:29:05]

Description was changed from

==========
Show autofill sync status in CBD

This changes the AutofillCounter to indicate that autofill data is synced.

BUG=681523
==========

to

==========
Show autofill sync status in CBD

This changes the AutofillCounter to indicate that autofill data is synced.

BUG=681523

Review-Url: https://codereview.chromium.org/2828083003
Cr-Commit-Position: refs/heads/master@{#468606}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae41773373496eaa692beb85a20c...
==========

[commit-bot: I haz the power, 2017-05-02 12:29:06]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/ae41773373496eaa692beb85a20c...