Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2828013002: Replace DCHECK with DCHECK_EQ and DCHECK_GT as appropriate in modules/accessibility (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DCHECK with DCHECK_EQ and DCHECK_GT as appropriate in modules/accessibility This CL is a followup to https://codereview.chromium.org/2804383002/ BUG=707651 Review-Url: https://codereview.chromium.org/2828013002 Cr-Commit-Position: refs/heads/master@{#465782} Committed: https://chromium.googlesource.com/chromium/src/+/adebcac2524f6ec77c87bec594154961130822ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
pilgrim_google
3 years, 8 months ago (2017-04-19 16:20:21 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-19 16:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828013002/1
3 years, 8 months ago (2017-04-19 18:17:32 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 22:26:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/adebcac2524f6ec77c87bec59415...

Powered by Google App Engine
This is Rietveld 408576698