Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2827983005:
[ios] Fix remoting application bundle. (Closed)
Description[ios] Fix remoting application bundle.
On iOS, the binary of an application bundle should be named after
the application bundle without the .app suffix (see [1]). As the
ios_app_bundle assumes this is the case but code_sign.py script
respects CFExecutableName, both value need to agree.
Fix the ios_remoting_app target by using the same value for the
"output_name" variable and the "EXECUTABLE_NAME" expansion.
[1]: https://developer.apple.com/library/content/documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html#//apple_ref/doc/uid/10000123i-CH101-SW1
BUG=713668
Review-Url: https://codereview.chromium.org/2827983005
Cr-Commit-Position: refs/heads/master@{#466385}
Committed: https://chromium.googlesource.com/chromium/src/+/2c711f7b56b771b19f2c3d1a458815d0eeafe6df
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + nicholss@chromium.org, wez@chromium.org
Please take a look. This changes the application bundle name from remoting-ios.app to chromoting.app. If another name needs to be used, then the remoting_ios_executable_name should be change to keep both output_name and EXECUTABLE_NAME in sync.
If this looks good to you, please send to CQ.
The CQ bit was unchecked by sdefresne@chromium.org
ping?
The CQ bit was checked by nicholss@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Looks like this broke the iOS/XCode/Clang build. ;-( Besides that, if Scott is happy then LGTM
jamiewalch@chromium.org changed reviewers: + jamiewalch@chromium.org
lgtm
The CQ bit was checked by jamiewalch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492793531665770, "parent_rev":
"fc73346d1a81f7c76c4fbb567439082f6e00e8c3", "commit_rev":
"2c711f7b56b771b19f2c3d1a458815d0eeafe6df"}
Message was sent while issue was closed.
Description was changed from ========== [ios] Fix remoting application bundle. On iOS, the binary of an application bundle should be named after the application bundle without the .app suffix (see [1]). As the ios_app_bundle assumes this is the case but code_sign.py script respects CFExecutableName, both value need to agree. Fix the ios_remoting_app target by using the same value for the "output_name" variable and the "EXECUTABLE_NAME" expansion. [1]: https://developer.apple.com/library/content/documentation/CoreFoundation/Conc... BUG=713668 ========== to ========== [ios] Fix remoting application bundle. On iOS, the binary of an application bundle should be named after the application bundle without the .app suffix (see [1]). As the ios_app_bundle assumes this is the case but code_sign.py script respects CFExecutableName, both value need to agree. Fix the ios_remoting_app target by using the same value for the "output_name" variable and the "EXECUTABLE_NAME" expansion. [1]: https://developer.apple.com/library/content/documentation/CoreFoundation/Conc... BUG=713668 Review-Url: https://codereview.chromium.org/2827983005 Cr-Commit-Position: refs/heads/master@{#466385} Committed: https://chromium.googlesource.com/chromium/src/+/2c711f7b56b771b19f2c3d1a4588... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2c711f7b56b771b19f2c3d1a4588...
Message was sent while issue was closed.
On 2017/04/21 17:56:45, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/2c711f7b56b771b19f2c3d1a4588... Thank you for the review. FTR, the ios-clang-xcode bot was broken by an unrelated issue (probably related to hermetic build). The build error was: 2017-04-20 05:17:12.070 ibtoold[72281:100828] CoreSimulator is attempting to unload a stale CoreSimulatorService job. Existing job (com.apple.CoreSimulator.CoreSimulatorService.179.1.E8ttyeDeVgWK) is from an older version and is being removed to prevent problems. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
