Added null safety for CSSParserContext in CSSPropertyLengthUtils.

Added null safety for CSSParserContext in CSSPropertyLengthUtils.

Changed CSSParserContext argument from * to & for null safety and
readability in CSSPropertyLengthUtils.

Follow up from https://codereview.chromium.org/2805153002

BUG=668012
Review-Url: https://codereview.chromium.org/2827963003
Cr-Commit-Position: refs/heads/master@{#465905}
Committed: https://chromium.googlesource.com/chromium/src/+/74c0237b4f109a9ac533ceba0ec82bb5f24bebfa

[Bugs Nash, 2017-04-20 00:05:16]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 00:05:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-20 00:06:05]

bugsnash@chromium.org changed reviewers:
+ rjwright@chromium.org

[commit-bot: I haz the power, 2017-04-20 01:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 01:31:25]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-04-20 03:13:36]

bugsnash@chromium.org changed reviewers:
+ shend@chromium.org
- rjwright@chromium.org

[Bugs Nash, 2017-04-20 03:13:37]

changed reviewer to shend as rjwright is ooo

[shend, 2017-04-20 03:30:13]

lgtm with nit.

https://codereview.chromium.org/2827963003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2827963003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1853:
DCHECK(context_);
Does this whole function assume context_ is not null? Perhaps move this DCHECK
to the beginning of the function? Or move it to when context_ gets its value
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/parse...
Or even, in a separate patch, declare context_ as a const ref on
CSSPropertyParser?

[Bugs Nash, 2017-04-20 03:55:18]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 03:55:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-20 03:55:40]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 03:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-20 03:56:15]

bugsnash@chromium.org changed reviewers:
+ alancutter@chromium.org

[Bugs Nash, 2017-04-20 03:56:15]

+alancutter for owners

https://codereview.chromium.org/2827963003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2827963003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1853:
DCHECK(context_);
On 2017/04/20 at 03:30:13, shend wrote:
> Does this whole function assume context_ is not null? Perhaps move this DCHECK
to the beginning of the function? Or move it to when context_ gets its value
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/parse...
Or even, in a separate patch, declare context_ as a const ref on
CSSPropertyParser?

moved DCHECK for now, will look into changing it to a const ref here in future

[Bugs Nash, 2017-04-20 03:56:48]

The CQ bit was unchecked by bugsnash@chromium.org

[Bugs Nash, 2017-04-20 03:57:02]

addressed review

[Bugs Nash, 2017-04-20 03:57:10]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 03:57:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2017-04-20 04:07:02]

lgtm

[Bugs Nash, 2017-04-20 04:10:21]

The CQ bit was unchecked by bugsnash@chromium.org

[Bugs Nash, 2017-04-20 04:10:24]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-04-20 04:10:24]

The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2827963003/#ps20001
(title: "addressed review")

[commit-bot: I haz the power, 2017-04-20 04:10:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 05:24:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492661424197590,
"parent_rev": "8a32f1b172e3ee37f98766eac4f8de5dc58dba8f", "commit_rev":
"74c0237b4f109a9ac533ceba0ec82bb5f24bebfa"}

[commit-bot: I haz the power, 2017-04-20 05:25:48]

Description was changed from

==========
Added null safety for CSSParserContext in CSSPropertyLengthUtils.

Changed CSSParserContext argument from * to & for null safety and
readability in CSSPropertyLengthUtils.

Follow up from https://codereview.chromium.org/2805153002

BUG=668012
==========

to

==========
Added null safety for CSSParserContext in CSSPropertyLengthUtils.

Changed CSSParserContext argument from * to & for null safety and
readability in CSSPropertyLengthUtils.

Follow up from https://codereview.chromium.org/2805153002

BUG=668012

Review-Url: https://codereview.chromium.org/2827963003
Cr-Commit-Position: refs/heads/master@{#465905}
Committed:
https://chromium.googlesource.com/chromium/src/+/74c0237b4f109a9ac533ceba0ec8...
==========

[commit-bot: I haz the power, 2017-04-20 05:25:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74c0237b4f109a9ac533ceba0ec8...