Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2827963002: Log PaymentResponse.complete() timeout. (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews, gogerald+paymentswatch_chromium.org, haraken, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Log PaymentResponse.complete() timeout. Before this patch, if the merchant website never calls PaymentResponse.complete(), then the UI shows a generic error dialog to the user and aborts payment, but nothing indicates to the web developer that it was a timeout that causes the closing of the web payment UI. The fix is to add a console error message "Timed out waiting for a PaymentResponse.complete() call" when the timer expires. After this patch, the console error message will indicate to the web developer that it was a timeout that causes the closing of the web payment UI. To test manually: 1) Open https://rsolomakhin.github.io/pr/ko/complete/. 2) Click [Buy] on the page. 3) Click [Pay] in the web payment UI. Observe: Console prints an error message after 60 seconds. BUG=711027 Review-Url: https://codereview.chromium.org/2827963002 Cr-Commit-Position: refs/heads/master@{#465694} Committed: https://chromium.googlesource.com/chromium/src/+/bb7503ea498af3d78bf3577c5a32d400b74d29b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 6 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
please use gerrit instead
Marijn, ptal.
3 years, 8 months ago (2017-04-19 14:52:59 UTC) #4
Marijn Kruisselbrink
lgtm
3 years, 8 months ago (2017-04-19 19:01:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827963002/1
3 years, 8 months ago (2017-04-19 19:06:54 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:12:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb7503ea498af3d78bf3577c5a32...

Powered by Google App Engine
This is Rietveld 408576698