Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2827933003: Move storage tests from content/common next to the files they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tzik, lcwu+watch_chromium.org, jam, nhiroki, darin-cc_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move storage tests from content/common next to the files they cover. I initially set up storage's unit tests target to live at //storage/browser:storage_unittests, because I didn't notice the tests hiding in content/common. This CL makes the target live at //storage:storage_unittests, so it can hold the tests in both storage/browser and storage/common. BUG=653751 Review-Url: https://codereview.chromium.org/2827933003 Cr-Commit-Position: refs/heads/master@{#466294} Committed: https://chromium.googlesource.com/chromium/src/+/9f1622acdaf14425d2363cdac6bd05e79585d2ee

Patch Set 1 #

Patch Set 2 : Add missing dep. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -730 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D content/common/database_connections_unittest.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D content/common/database_identifier_unittest.cc View 1 chunk +0 lines, -287 lines 0 comments Download
D content/common/fileapi/file_system_util_unittest.cc View 1 chunk +0 lines, -310 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
A storage/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M storage/common/BUILD.gn View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + storage/common/database/database_connections_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/common/database/database_identifier_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/common/fileapi/file_system_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (15 generated)
pwnall
halliwell@chromium.org: Please review the move from //storage/browser:storage_unittests to //storage:storage_unittests in chromecast/BUILD.gn phajdan.jr@chromium.org: Please review the ...
3 years, 8 months ago (2017-04-20 00:24:39 UTC) #8
halliwell
On 2017/04/20 00:24:39, pwnall wrote: > mailto:halliwell@chromium.org: Please review the move from > //storage/browser:storage_unittests to ...
3 years, 8 months ago (2017-04-20 01:21:22 UTC) #11
kinuko
lgtm
3 years, 8 months ago (2017-04-20 02:24:29 UTC) #12
pwnall
halliwell, kinuko: Thank you very much for your quick review! dpranke: Can you please review ...
3 years, 8 months ago (2017-04-20 23:36:44 UTC) #14
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-21 00:19:58 UTC) #15
pwnall
On 2017/04/21 00:19:58, Dirk Pranke wrote: > lgtm Thank you very much for the quick ...
3 years, 8 months ago (2017-04-21 00:20:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827933003/20001
3 years, 8 months ago (2017-04-21 00:20:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/394521) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 8 months ago (2017-04-21 00:22:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827933003/20001
3 years, 8 months ago (2017-04-21 09:35:52 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 09:39:14 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9f1622acdaf14425d2363cdac6bd...

Powered by Google App Engine
This is Rietveld 408576698