Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2827923002: Change dummy package name so it doesn't include a reserved word. (Closed)

Created:
3 years, 8 months ago by sakal-chromium
Modified:
3 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, Peter Wen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change dummy package name so it doesn't include a reserved word. Using dummy.package as a package name causes problems in Android Studio 2.3. BUG=webrtc:7498, 700438 Review-Url: https://codereview.chromium.org/2827923002 Cr-Commit-Position: refs/heads/master@{#465624} Committed: https://chromium.googlesource.com/chromium/src/+/7acdbdd51897c2abc030f06ecfec9116ea5bee26

Patch Set 1 #

Patch Set 2 : Rename the rest of the occurrences. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gradle/android.jinja View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/process_resources.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
sakal-chromium
PTAL
3 years, 8 months ago (2017-04-19 09:55:36 UTC) #4
agrieve
On 2017/04/19 09:55:36, sakal-chromium wrote: > PTAL Makes sense to fix, but I think there ...
3 years, 8 months ago (2017-04-19 14:06:55 UTC) #5
sakal-chromium
On 2017/04/19 14:06:55, agrieve wrote: > On 2017/04/19 09:55:36, sakal-chromium wrote: > > PTAL > ...
3 years, 8 months ago (2017-04-19 14:40:50 UTC) #7
agrieve
On 2017/04/19 14:40:50, sakal-chromium wrote: > On 2017/04/19 14:06:55, agrieve wrote: > > On 2017/04/19 ...
3 years, 8 months ago (2017-04-19 14:51:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827923002/40001
3 years, 8 months ago (2017-04-19 14:52:55 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:56:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7acdbdd51897c2abc030f06ecfec...

Powered by Google App Engine
This is Rietveld 408576698