Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2827913002: Change WebLocalFrame::SpellingMarkerOffsetsForTest to a local function in WebFrameTest (Closed)

Created:
3 years, 8 months ago by Xiaocheng
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change WebLocalFrame::SpellingMarkerOffsetsForTest to a local function in WebFrameTest The above mentioned function is only used in WebFrameTest, so this patch moves it to WebFrameTest.cpp as a static function for better code health. BUG=711509 Review-Url: https://codereview.chromium.org/2827913002 Cr-Commit-Position: refs/heads/master@{#465850} Committed: https://chromium.googlesource.com/chromium/src/+/34b5b42e28359dad00ab6f66a2516539a87422f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 4 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Xiaocheng
PTAL.
3 years, 8 months ago (2017-04-20 00:22:59 UTC) #8
tkent
lgtm
3 years, 8 months ago (2017-04-20 00:49:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827913002/1
3 years, 8 months ago (2017-04-20 01:30:35 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 01:35:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34b5b42e28359dad00ab6f66a251...

Powered by Google App Engine
This is Rietveld 408576698