Hide cold mode idle time spellchecker behind a flag

Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters cold mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The unit tests are modified accordingly so that the lifecycle transition
without the flag is also tested.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006
Review-Url: https://codereview.chromium.org/2827903002
Cr-Commit-Position: refs/heads/master@{#465855}
Committed: https://chromium.googlesource.com/chromium/src/+/234a68c81bb610d29c3bcabc08dcd4485ee58f06

[Xiaocheng, 2017-04-19 07:21:13]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[Xiaocheng, 2017-04-19 07:24:08]

Description was changed from

==========
Hide cold mode idle time spellchecker behind a flag

BUG=713006
==========

to

==========
Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters code mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006
==========

[Xiaocheng, 2017-04-19 07:25:29]

Description was changed from

==========
Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters code mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006
==========

to

==========
Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters code mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The unit tests are modified accordingly so that the lifecycle transition
without the flag is also tested.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006
==========

[Xiaocheng, 2017-04-19 07:26:48]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 07:27:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-04-19 08:42:44]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org, yosin@chromium.org

[Xiaocheng, 2017-04-19 08:42:44]

I realized that the hot and cold modes of idle time spell checker are doing very
different things, and hence, should be tested and shipped separately. Hence I'm
adding this flag.

PTAL.

[tkent, 2017-04-19 08:48:22]

lgtm

CL description:
> so that idle time spellchecker enters code mode only when the flag

code -> cold?

[Xiaocheng, 2017-04-19 08:50:58]

On 2017/04/19 at 08:48:22, tkent wrote:
> lgtm
> 
> CL description:
> > so that idle time spellchecker enters code mode only when the flag
> 
> code -> cold?

Good catch...

[Xiaocheng, 2017-04-19 08:51:13]

Description was changed from

==========
Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters code mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The unit tests are modified accordingly so that the lifecycle transition
without the flag is also tested.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006
==========

to

==========
Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters cold mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The unit tests are modified accordingly so that the lifecycle transition
without the flag is also tested.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006
==========

[commit-bot: I haz the power, 2017-04-19 09:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 09:38:57]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-20 01:10:45]

lgtm

https://codereview.chromium.org/2827903002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2827903002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:497: name:
"IdleTimeColdModeSpellChecking",
Is it better to have a comment that IdleTimeColdModeSpeillChecking will work if
IdleTimeSpellChecking enabled?

[Xiaocheng, 2017-04-20 01:40:09]

Thanks for reviewing!

https://codereview.chromium.org/2827903002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2827903002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:497: name:
"IdleTimeColdModeSpellChecking",
On 2017/04/20 at 01:10:45, yosin_UTC9 wrote:
> Is it better to have a comment that IdleTimeColdModeSpeillChecking will work
if IdleTimeSpellChecking enabled?

I think there's no need to add a comment that says the same thing as the code...

[Xiaocheng, 2017-04-20 01:43:54]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-04-20 01:44:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 01:49:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492652634971070, "parent_rev":
"f5f56eaf9aa0338be5de51380df8cf90814e2444", "commit_rev":
"234a68c81bb610d29c3bcabc08dcd4485ee58f06"}

[commit-bot: I haz the power, 2017-04-20 01:49:13]

Description was changed from

==========
Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters cold mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The unit tests are modified accordingly so that the lifecycle transition
without the flag is also tested.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006
==========

to

==========
Hide cold mode idle time spellchecker behind a flag

This patch adds a new runtime flag IdleTimeColdModeSpellChecking,
so that idle time spellchecker enters cold mode only when the flag
is enabled --- otherwise it enters the inactive state instead.

The unit tests are modified accordingly so that the lifecycle transition
without the flag is also tested.

The purpose of the new flag is for shipping hot and cold modes of
idle time spellchecker separately.

BUG=713006

Review-Url: https://codereview.chromium.org/2827903002
Cr-Commit-Position: refs/heads/master@{#465855}
Committed:
https://chromium.googlesource.com/chromium/src/+/234a68c81bb610d29c3bcabc08dc...
==========

[commit-bot: I haz the power, 2017-04-20 01:49:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/234a68c81bb610d29c3bcabc08dc...