Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2827853003: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/media_galleries (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang, tommycli, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/media_galleries This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 Review-Url: https://codereview.chromium.org/2827853003 Cr-Commit-Position: refs/heads/master@{#465766} Committed: https://chromium.googlesource.com/chromium/src/+/2edbc3bc672529ac4719225697cfb4085dfd0c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -125 lines) Patch
M chrome/browser/media_galleries/fileapi/iapps_finder_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 3 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 17 chunks +45 lines, -57 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/media_galleries/gallery_watch_manager.cc View 6 chunks +16 lines, -23 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tzik
PTAL
3 years, 8 months ago (2017-04-19 13:42:33 UTC) #6
Lei Zhang
lgtm
3 years, 8 months ago (2017-04-19 21:43:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827853003/1
3 years, 8 months ago (2017-04-19 21:43:31 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 21:49:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2edbc3bc672529ac4719225697cf...

Powered by Google App Engine
This is Rietveld 408576698