Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2827823002: wpt-importer: Don't run git cl set-close when there are no try job results. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

wpt-importer: Don't run git cl set-close when there are no try job results. Originally in the do_auto_update method of the importer, I added a section: if not try_results: _log.error('No try job results.') self.git_cl.run(['set-close']) return False The purpose of this was to abort and indicate failure if something went completely wrong with the CQ; I was expecting that try_results should contain CQ bot try results like: { 'builder_name': 'linux_chromium_rel_ng', 'status': 'COMPLETED', 'result': 'SUCCESS', }, ... But apparently this isn't the case, although I'm not sure why. This CL replaces that section with just logging the try_results list and continuing, which I believe should work as intened anyway and will help us understand what try_results actually contains. BUG=702761 Review-Url: https://codereview.chromium.org/2827823002 Cr-Commit-Position: refs/heads/master@{#465445} Committed: https://chromium.googlesource.com/chromium/src/+/7865cc51cb1ebe2c072f62f7de98723e0f326c59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
3 years, 8 months ago (2017-04-18 22:37:24 UTC) #2
jeffcarp
lgtm
3 years, 8 months ago (2017-04-18 23:41:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827823002/1
3 years, 8 months ago (2017-04-18 23:42:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827823002/1
3 years, 8 months ago (2017-04-19 00:15:40 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 00:42:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7865cc51cb1ebe2c072f62f7de98...

Powered by Google App Engine
This is Rietveld 408576698