Chromium Code Reviews
Descriptionwpt-importer: Don't run git cl set-close when there are no try job results.
Originally in the do_auto_update method of the importer, I added
a section:
if not try_results:
_log.error('No try job results.')
self.git_cl.run(['set-close']) return False
The purpose of this was to abort and indicate failure if something went
completely wrong with the CQ; I was expecting that try_results should
contain CQ bot try results like:
{
'builder_name': 'linux_chromium_rel_ng', 'status':
'COMPLETED', 'result': 'SUCCESS',
}, ...
But apparently this isn't the case, although I'm not sure why.
This CL replaces that section with just logging the try_results list
and continuing, which I believe should work as intened anyway and
will help us understand what try_results actually contains.
BUG=702761
Review-Url: https://codereview.chromium.org/2827823002
Cr-Commit-Position: refs/heads/master@{#465445}
Committed: https://chromium.googlesource.com/chromium/src/+/7865cc51cb1ebe2c072f62f7de98723e0f326c59
Patch Set 1 #
Messages
Total messages: 14 (9 generated)
|
|||||||||||||||||||