Fix fp16 mode on intel gpus.

Fix fp16 mode on intel gpus.

BUG=711516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2827793004
Cr-Commit-Position: refs/heads/master@{#466186}
Committed: https://chromium.googlesource.com/chromium/src/+/92dc022ddbd78f9f7ca77d9fc072b636c96b9c06

[hubbe, 2017-04-18 23:04:49]

Description was changed from

==========
Fix fp16 mode on intel gpus.

BUG=711516
==========

to

==========
Fix fp16 mode on intel gpus.

BUG=711516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hubbe, 2017-04-18 23:04:53]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 23:05:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 23:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 23:41:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hubbe, 2017-04-19 21:33:06]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 21:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 21:37:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 21:37:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[hubbe, 2017-04-19 22:08:40]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 22:09:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:50:14]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[hubbe, 2017-04-19 23:28:09]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 01:19:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 01:19:41]

Dry run: This issue passed the CQ dry run.

[hubbe, 2017-04-20 17:13:39]

hubbe@chromium.org changed reviewers:
+ jbauman@chromium.org

[jbauman, 2017-04-20 19:41:10]

https://codereview.chromium.org/2827793004/diff/60001/media/gpu/dxva_video_de...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2827793004/diff/60001/media/gpu/dxva_video_de...
media/gpu/dxva_video_decode_accelerator_win.cc:816: if (use_fp16_ ||
!share_nv12_textures_) {
Could we set share_nv12_textures_ before this if we're using fp16?  Because in
that case we're not actually sharing nv12 textures.

[hubbe, 2017-04-20 19:43:16]

https://codereview.chromium.org/2827793004/diff/60001/media/gpu/dxva_video_de...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2827793004/diff/60001/media/gpu/dxva_video_de...
media/gpu/dxva_video_decode_accelerator_win.cc:816: if (use_fp16_ ||
!share_nv12_textures_) {
On 2017/04/20 19:41:10, jbauman wrote:
> Could we set share_nv12_textures_ before this if we're using fp16?  Because in
> that case we're not actually sharing nv12 textures.

Problem is that use_fp16_ can become false later if we fail to get an fp16
context from egl further down..

[jbauman, 2017-04-20 19:53:04]

On 2017/04/20 19:43:16, hubbe wrote:
>
https://codereview.chromium.org/2827793004/diff/60001/media/gpu/dxva_video_de...
> File media/gpu/dxva_video_decode_accelerator_win.cc (right):
> 
>
https://codereview.chromium.org/2827793004/diff/60001/media/gpu/dxva_video_de...
> media/gpu/dxva_video_decode_accelerator_win.cc:816: if (use_fp16_ ||
> !share_nv12_textures_) {
> On 2017/04/20 19:41:10, jbauman wrote:
> > Could we set share_nv12_textures_ before this if we're using fp16?  Because
in
> > that case we're not actually sharing nv12 textures.
> 
> Problem is that use_fp16_ can become false later if we fail to get an fp16
> context from egl further down..

Ok, that's not great, but I guess we can live with it. lgtm

[hubbe, 2017-04-20 20:08:23]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2017-04-20 20:09:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 20:18:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hubbe, 2017-04-20 20:39:30]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 20:40:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:27:56]

Dry run: This issue passed the CQ dry run.

[hubbe, 2017-04-20 23:19:02]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2017-04-20 23:19:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2827793004/#ps70004
(title: "oops, had an extra file")

[commit-bot: I haz the power, 2017-04-20 23:19:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 23:22:58]

CQ is committing da patch.

Bot data: {"patchset_id": 70004, "attempt_start_ts": 1492730342547920,
"parent_rev": "5df3c973662600cb69c4d5e6ac8ae0d1870d10dc", "commit_rev":
"92dc022ddbd78f9f7ca77d9fc072b636c96b9c06"}

[commit-bot: I haz the power, 2017-04-20 23:23:14]

Description was changed from

==========
Fix fp16 mode on intel gpus.

BUG=711516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix fp16 mode on intel gpus.

BUG=711516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2827793004
Cr-Commit-Position: refs/heads/master@{#466186}
Committed:
https://chromium.googlesource.com/chromium/src/+/92dc022ddbd78f9f7ca77d9fc072...
==========

[commit-bot: I haz the power, 2017-04-20 23:23:15]

Committed patchset #5 (id:70004) as
https://chromium.googlesource.com/chromium/src/+/92dc022ddbd78f9f7ca77d9fc072...