Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2827773003: Restore Payments shipping address info when changing country (Closed)

Created:
3 years, 8 months ago by MAD
Modified:
3 years, 8 months ago
Reviewers:
tmartino, anthonyvd
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore Payments shipping address info when changing country BUG=703764 Review-Url: https://codereview.chromium.org/2827773003 Cr-Commit-Position: refs/heads/master@{#466023} Committed: https://chromium.googlesource.com/chromium/src/+/9a045e38e70b45fc518b3e790748b4ca02ffd30d

Patch Set 1 #

Patch Set 2 : Fix other platforms compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -64 lines) Patch
M chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc View 6 chunks +57 lines, -42 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc View 1 8 chunks +102 lines, -22 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
MAD
I was going to move some of this code to the base class, but it's ...
3 years, 8 months ago (2017-04-19 13:18:45 UTC) #10
tmartino
lgtm If you're interested, you can see https://codereview.chromium.org/2816083002 for a sense of how I structured ...
3 years, 8 months ago (2017-04-19 17:24:54 UTC) #11
MAD
Thanks Tommy. +anthonyvd for OWNERS approval. BYE MAD
3 years, 8 months ago (2017-04-19 17:57:09 UTC) #13
anthonyvd
lgtm
3 years, 8 months ago (2017-04-20 14:26:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827773003/20001
3 years, 8 months ago (2017-04-20 14:56:54 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 15:44:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a045e38e70b45fc518b3e790748...

Powered by Google App Engine
This is Rietveld 408576698