Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2827743002: [ARM] Reserve scratch q-register. (Closed)

Created:
3 years, 8 months ago by bbudge
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Reserve scratch q-register. - Reserves q15 (d30,d31) as a scratch register for NEON operations. - Rewrites CodeGenerator::AssembleSwap to use it. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2827743002 Cr-Commit-Position: refs/heads/master@{#44728} Committed: https://chromium.googlesource.com/v8/v8/+/246a7bdd26198ea38d174797160631c6904966b7

Patch Set 1 #

Patch Set 2 : Overlap d- and q- scratch registers to get back 1 allocatable d-register. #

Patch Set 3 : Fix issue with allocatable double registers without VFP32DREGS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M src/arm/assembler-arm.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +26 lines, -26 lines 0 comments Download
M src/register-configuration.cc View 1 2 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
bbudge
3 years, 8 months ago (2017-04-18 19:16:23 UTC) #6
Benedikt Meurer
lgtm
3 years, 8 months ago (2017-04-19 03:58:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827743002/40001
3 years, 8 months ago (2017-04-19 16:55:10 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 16:56:49 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/246a7bdd26198ea38d174797160631c6904...

Powered by Google App Engine
This is Rietveld 408576698