Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2827693003: ImageCapture: don't list |torch| in Capabilities if not supported (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, haraken, blink-reviews, mcasas+imagecapture_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageCapture: don't list |torch| in Capabilities if not supported Currently MediaStreamTrack.getCapabilities() returns torch : false when |torch| is not supported; this CL aligns with the other dictionary members behaviour, which is to not show up in the Capabilities dictionary when not supported. BUG=712719 Review-Url: https://codereview.chromium.org/2827693003 Cr-Commit-Position: refs/heads/master@{#465373} Committed: https://chromium.googlesource.com/chromium/src/+/31b31da235decd6c593745e98f77b55ff9270cb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mcasas
reillyg@ tiny CL, ptal
3 years, 8 months ago (2017-04-18 18:03:06 UTC) #5
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-18 18:05:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827693003/1
3 years, 8 months ago (2017-04-18 18:57:37 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:10:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31b31da235decd6c593745e98f77...

Powered by Google App Engine
This is Rietveld 408576698