Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2827643004: [LayoutNG] Add FlagExpectations for LayoutNG 1/3 (Closed)

Created:
3 years, 8 months ago by kojii
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add FlagExpectations for LayoutNG 1/3 This patch adds the FlagExpectations file for LayoutNG. The patch is split into 3 CLs because it hits the max limit of CQ. There are many flaky tests that may need multiple passes until it is stabilized. BUG=591099 Review-Url: https://codereview.chromium.org/2827643004 Cr-Commit-Position: refs/heads/master@{#466571} Committed: https://chromium.googlesource.com/chromium/src/+/5d44f961b168a6cff0f822455b03cbca3eb44855

Patch Set 1 #

Patch Set 2 : Add more results #

Patch Set 3 : Add more results #

Patch Set 4 : Add more results #

Patch Set 5 : Add more results #

Patch Set 6 : Add more results #

Patch Set 7 : Add more results #

Patch Set 8 : Add more results #

Patch Set 9 : Add more results #

Patch Set 10 : Add more results #

Patch Set 11 : Reduced to 9500 lines #

Patch Set 12 : Removed recently removed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9499 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +9499 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (25 generated)
kojii
PTAL. After "exists early" was handled, many tests are flaky that we might need several ...
3 years, 8 months ago (2017-04-23 08:30:09 UTC) #19
eae
LGTM, thank you for doing this!
3 years, 8 months ago (2017-04-23 23:49:09 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827643004/180002
3 years, 8 months ago (2017-04-23 23:49:35 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-23 23:54:18 UTC) #29
Message was sent while issue was closed.
Committed patchset #12 (id:180002) as
https://chromium.googlesource.com/chromium/src/+/5d44f961b168a6cff0f822455b03...

Powered by Google App Engine
This is Rietveld 408576698