Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2827643002: [ObjC ARC] Converts ios/chrome/browser/ui/side_swipe:side_swipe to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/side_swipe:side_swipe to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2827643002 Cr-Commit-Position: refs/heads/master@{#465577} Committed: https://chromium.googlesource.com/chromium/src/+/1f851d02ff8f6825b592fc8f980cd48b640e10f4

Patch Set 1 #

Patch Set 2 : weak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -54 lines) Patch
M ios/chrome/browser/ui/side_swipe/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/card_side_swipe_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/history_side_swipe_provider.mm View 1 1 chunk +7 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/side_swipe/side_swipe_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm View 14 chunks +37 lines, -37 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm View 7 chunks +8 lines, -10 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/side_swipe_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-19 12:02:23 UTC) #8
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-19 13:17:30 UTC) #9
stkhapugin
Thank you!
3 years, 8 months ago (2017-04-19 13:22:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827643002/20001
3 years, 8 months ago (2017-04-19 13:23:10 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 13:28:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f851d02ff8f6825b592fc8f980c...

Powered by Google App Engine
This is Rietveld 408576698