[regexp] explicitly whitelist allowed binary property classes.

[regexp] explicitly whitelist allowed binary property classes.

BUG=v8:4743
TBR=jgruber@chromium.org

Review-Url: https://codereview.chromium.org/2827613002
Cr-Commit-Position: refs/heads/master@{#44677}
Committed: https://chromium.googlesource.com/v8/v8/+/4f3d859f318bcfd462c9a8b394b23185775306ae

[Yang, 2017-04-18 07:30:22]

Description was changed from

==========
[regexp] explicitly whitelist allowed binary property classes.

BUG=v8:4743
==========

to

==========
[regexp] explicitly whitelist allowed binary property classes.

BUG=v8:4743
TBR=jgruber@chromium.org
==========

[Yang, 2017-04-18 07:30:22]

yangguo@chromium.org changed reviewers:
+ jgruber@chromium.org, mathias@qiwi.be

[Yang, 2017-04-18 07:30:29]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 07:30:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-18 07:31:43]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 07:31:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-18 07:48:20]

Please take a look!

[commit-bot: I haz the power, 2017-04-18 07:56:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 07:56:31]

Dry run: This issue passed the CQ dry run.

[mathias, 2017-04-18 08:29:38]

LGTM

https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:1209: case UCHAR_ALPHABETIC:
Maybe add a comment here explaining that Any and ASCII are implemented
separately? Useful when cross-referencing with the list in the spec.

https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:1210: case UCHAR_ASCII_HEX_DIGIT:
Same here with `Assigned`.

[Yang, 2017-04-18 09:36:05]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-18 09:36:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mathias@qiwi.be
Link to the patchset: https://codereview.chromium.org/2827613002/#ps40001
(title: "add comments")

[commit-bot: I haz the power, 2017-04-18 09:36:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-18 09:36:20]

On 2017/04/18 08:29:38, mathias wrote:
> LGTM
> 
>
https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
> File src/regexp/regexp-parser.cc (right):
> 
>
https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
> src/regexp/regexp-parser.cc:1209: case UCHAR_ALPHABETIC:
> Maybe add a comment here explaining that Any and ASCII are implemented
> separately? Useful when cross-referencing with the list in the spec.
> 
>
https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
> src/regexp/regexp-parser.cc:1210: case UCHAR_ASCII_HEX_DIGIT:
> Same here with `Assigned`.

Done.

[mathias, 2017-04-18 10:00:58]

On 2017/04/18 09:36:20, Yang wrote:
> On 2017/04/18 08:29:38, mathias wrote:
> > LGTM
> > 
> >
>
https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
> > File src/regexp/regexp-parser.cc (right):
> > 
> >
>
https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
> > src/regexp/regexp-parser.cc:1209: case UCHAR_ALPHABETIC:
> > Maybe add a comment here explaining that Any and ASCII are implemented
> > separately? Useful when cross-referencing with the list in the spec.
> > 
> >
>
https://codereview.chromium.org/2827613002/diff/20001/src/regexp/regexp-parse...
> > src/regexp/regexp-parser.cc:1210: case UCHAR_ASCII_HEX_DIGIT:
> > Same here with `Assigned`.
> 
> Done.

Re: Any/ASCII/Assigned — hopefully these will be added to ICU as part of
https://ssl.icu-project.org/trac/ticket/13150.

[commit-bot: I haz the power, 2017-04-18 10:01:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492508165771450,
"parent_rev": "8cb861bf72a8188759237ca1ac5345c03dad29f8", "commit_rev":
"4f3d859f318bcfd462c9a8b394b23185775306ae"}

[commit-bot: I haz the power, 2017-04-18 10:01:32]

Description was changed from

==========
[regexp] explicitly whitelist allowed binary property classes.

BUG=v8:4743
TBR=jgruber@chromium.org
==========

to

==========
[regexp] explicitly whitelist allowed binary property classes.

BUG=v8:4743
TBR=jgruber@chromium.org

Review-Url: https://codereview.chromium.org/2827613002
Cr-Commit-Position: refs/heads/master@{#44677}
Committed:
https://chromium.googlesource.com/v8/v8/+/4f3d859f318bcfd462c9a8b394b23185775...
==========

[commit-bot: I haz the power, 2017-04-18 10:01:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/4f3d859f318bcfd462c9a8b394b23185775...