Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2827583003: Move cast overlay CSS selector deprecation deadline to 61. (Closed)

Created:
3 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, whywhat
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move cast overlay CSS selector deprecation deadline to 61. Unfortunately, the usage increased since the deprecation started, making the deprecation a bit more involved. BUG=678285 R=foolip@chromium.org Review-Url: https://codereview.chromium.org/2827583003 Cr-Commit-Position: refs/heads/master@{#465387} Committed: https://chromium.googlesource.com/chromium/src/+/25800fa49e1e6176b11bac60f20e031363e1bd97

Patch Set 1 #

Patch Set 2 : update layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/media/deprecated-css-selectors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mlamouri (slow - plz ping)
+foolip@ PTAL CC avayvod@ FYI
3 years, 8 months ago (2017-04-18 10:04:22 UTC) #1
foolip
lgtm
3 years, 8 months ago (2017-04-18 10:06:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827583003/20001
3 years, 8 months ago (2017-04-18 17:37:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:49:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25800fa49e1e6176b11bac60f20e...

Powered by Google App Engine
This is Rietveld 408576698