MD Bookmarks: Show toolbar overlay when multiple items are selected

MD Bookmarks: Show toolbar overlay when multiple items are selected

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2827573002
Cr-Commit-Position: refs/heads/master@{#467582}
Committed: https://chromium.googlesource.com/chromium/src/+/92e0de602a4ca4b47313fc4095298755cdfd3cfb

[tsergeant, 2017-04-18 00:41:33]

Description was changed from

==========
MD Bookmarks: Show toolbar overlay when multiple items are selected

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
==========

to

==========
MD Bookmarks: Show toolbar overlay when multiple items are selected

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-18 01:02:08]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 01:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 02:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:13:18]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-04-18 05:29:46]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-04-24 04:26:12]

Fixed the problem you were seeing

[tsergeant, 2017-04-24 04:26:19]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 04:26:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-04-24 06:06:39]

More or less lg.

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.html (right):

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:42: @media (min-width: 901px)
{
=S

Any way to factor this into a css variable in cr somewhere?

Toolbar breakpoints should be configurable from a single place.

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:90:
selection-label="[[numberOfItemsSelected_(selectedCount_)]]"
nit: (get)itemsSelectedString_

[tsergeant, 2017-04-24 06:49:10]

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.html (right):

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:42: @media (min-width: 901px)
{
On 2017/04/24 06:06:38, calamity wrote:
> =S
> 
> Any way to factor this into a css variable in cr somewhere?
> 
> Toolbar breakpoints should be configurable from a single place.

You can't have CSS variables in media queries, but I've made cr-toolbar's
`narrow` property public, which means we can bind it up and use it.

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:90:
selection-label="[[numberOfItemsSelected_(selectedCount_)]]"
On 2017/04/24 06:06:38, calamity wrote:
> nit: (get)itemsSelectedString_

Done.

[tsergeant, 2017-04-24 06:49:17]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 06:49:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 09:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 09:14:27]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-26 10:13:25]

lgtm

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.html (right):

https://codereview.chromium.org/2827573002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.html:42: @media (min-width: 901px)
{
On 2017/04/24 06:49:10, tsergeant wrote:
> On 2017/04/24 06:06:38, calamity wrote:
> > =S
> > 
> > Any way to factor this into a css variable in cr somewhere?
> > 
> > Toolbar breakpoints should be configurable from a single place.
> 
> You can't have CSS variables in media queries, but I've made cr-toolbar's
> `narrow` property public, which means we can bind it up and use it.

Wew.

[tsergeant, 2017-04-26 23:23:14]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:24:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 02:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 02:28:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-04-27 02:47:06]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-04-27 02:47:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:46:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493261226837960,
"parent_rev": "68612719a16f976f78ab504a98295dc120d14852", "commit_rev":
"92e0de602a4ca4b47313fc4095298755cdfd3cfb"}

[commit-bot: I haz the power, 2017-04-27 04:46:29]

Description was changed from

==========
MD Bookmarks: Show toolbar overlay when multiple items are selected

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Show toolbar overlay when multiple items are selected

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2827573002
Cr-Commit-Position: refs/heads/master@{#467582}
Committed:
https://chromium.googlesource.com/chromium/src/+/92e0de602a4ca4b47313fc409529...
==========

[commit-bot: I haz the power, 2017-04-27 04:46:30]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/92e0de602a4ca4b47313fc409529...