Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issue 2827563002: Merge jumplist delete task and update task (Closed)

Created:
3 years, 8 months ago by chengx
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge jumplist delete task and update task This allows consistent comparison of time cost to the previous versions of jumplist implementation. Code-wise, it merges the DeleteDirectoryAndLogResults method into the RunUpdateJumplist method. This CL also logs the execution time of DeleteDirectoryContentAndLogResults to UMA. BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2827563002 Cr-Commit-Position: refs/heads/master@{#465136} Committed: https://chromium.googlesource.com/chromium/src/+/88ce9f2e84043c5f63cfb7a05cceffef8a581e97

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/browser/win/jumplist.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/win/jumplist_file_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
chengx
This is a small CL refactoring the code which allows consistent comparison of execution time, ...
3 years, 8 months ago (2017-04-17 22:10:58 UTC) #7
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-04-18 00:10:01 UTC) #10
Patrick Monette
lgtm https://codereview.chromium.org/2827563002/diff/1/chrome/browser/win/jumplist.cc File chrome/browser/win/jumplist.cc (right): https://codereview.chromium.org/2827563002/diff/1/chrome/browser/win/jumplist.cc#newcode613 chrome/browser/win/jumplist.cc:613: // of 1) delete old icons, 2) create ...
3 years, 8 months ago (2017-04-18 01:58:32 UTC) #11
chengx
Typo fixed. Thanks! https://codereview.chromium.org/2827563002/diff/1/chrome/browser/win/jumplist.cc File chrome/browser/win/jumplist.cc (right): https://codereview.chromium.org/2827563002/diff/1/chrome/browser/win/jumplist.cc#newcode613 chrome/browser/win/jumplist.cc:613: // of 1) delete old icons, ...
3 years, 8 months ago (2017-04-18 02:13:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827563002/20001
3 years, 8 months ago (2017-04-18 04:08:10 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 04:12:44 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88ce9f2e84043c5f63cfb7a05cce...

Powered by Google App Engine
This is Rietveld 408576698