Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2827543005: Fix wrong inclusion of .cc file in sync/ (Closed)

Created:
3 years, 8 months ago by emaxx
Modified:
3 years, 8 months ago
Reviewers:
stanisc, pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong inclusion of .cc file in sync/ BUG=713138 Review-Url: https://codereview.chromium.org/2827543005 Cr-Commit-Position: refs/heads/master@{#465584} Committed: https://chromium.googlesource.com/chromium/src/+/95b503e31f50d5acbeb3f7a7ba23cdbe20fb2b7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/sync/test/integration/sessions_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
emaxx
stanisc@: PTAL.
3 years, 8 months ago (2017-04-19 12:50:09 UTC) #6
pavely
lgtm
3 years, 8 months ago (2017-04-19 13:42:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827543005/1
3 years, 8 months ago (2017-04-19 13:46:46 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 13:51:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95b503e31f50d5acbeb3f7a7ba23...

Powered by Google App Engine
This is Rietveld 408576698