Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 2827543003: Display ETLD+1 instead of the full domain in MacOSX native notifications (Closed)

Created:
3 years, 8 months ago by Miguel Garcia
Modified:
3 years, 8 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Display ETLD+1 instead of the full domain in MacOSX native notifications BUG= Review-Url: https://codereview.chromium.org/2827543003 Cr-Commit-Position: refs/heads/master@{#465242} Committed: https://chromium.googlesource.com/chromium/src/+/d59da4c16d22505774ca9f9eae89402bec6efdc2

Patch Set 1 #

Total comments: 4

Patch Set 2 : review #

Total comments: 4

Patch Set 3 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -12 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 1 2 3 chunks +22 lines, -8 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm View 1 5 chunks +50 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Miguel Garcia
3 years, 8 months ago (2017-04-18 11:07:55 UTC) #4
Peter Beverloo
https://codereview.chromium.org/2827543003/diff/1/chrome/browser/notifications/notification_platform_bridge_mac.mm File chrome/browser/notifications/notification_platform_bridge_mac.mm (right): https://codereview.chromium.org/2827543003/diff/1/chrome/browser/notifications/notification_platform_bridge_mac.mm#newcode199 chrome/browser/notifications/notification_platform_bridge_mac.mm:199: NSString* subtitle = Could we maybe split this out ...
3 years, 8 months ago (2017-04-18 13:43:45 UTC) #7
Miguel Garcia
https://codereview.chromium.org/2827543003/diff/1/chrome/browser/notifications/notification_platform_bridge_mac.mm File chrome/browser/notifications/notification_platform_bridge_mac.mm (right): https://codereview.chromium.org/2827543003/diff/1/chrome/browser/notifications/notification_platform_bridge_mac.mm#newcode199 chrome/browser/notifications/notification_platform_bridge_mac.mm:199: NSString* subtitle = On 2017/04/18 13:43:45, Peter Beverloo wrote: ...
3 years, 8 months ago (2017-04-18 14:44:24 UTC) #8
Peter Beverloo
lgtm https://codereview.chromium.org/2827543003/diff/20001/chrome/browser/notifications/notification_platform_bridge_mac.mm File chrome/browser/notifications/notification_platform_bridge_mac.mm (right): https://codereview.chromium.org/2827543003/diff/20001/chrome/browser/notifications/notification_platform_bridge_mac.mm#newcode132 chrome/browser/notifications/notification_platform_bridge_mac.mm:132: NotificationCommon::Type notification_type) { nit: I'd prefer to pass ...
3 years, 8 months ago (2017-04-18 14:48:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827543003/40001
3 years, 8 months ago (2017-04-18 14:58:26 UTC) #12
Miguel Garcia
https://codereview.chromium.org/2827543003/diff/20001/chrome/browser/notifications/notification_platform_bridge_mac.mm File chrome/browser/notifications/notification_platform_bridge_mac.mm (right): https://codereview.chromium.org/2827543003/diff/20001/chrome/browser/notifications/notification_platform_bridge_mac.mm#newcode132 chrome/browser/notifications/notification_platform_bridge_mac.mm:132: NotificationCommon::Type notification_type) { On 2017/04/18 14:48:54, Peter Beverloo wrote: ...
3 years, 8 months ago (2017-04-18 14:59:10 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 15:18:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d59da4c16d22505774ca9f9eae89...

Powered by Google App Engine
This is Rietveld 408576698