Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2827503002: Add extra headers argument so we don't pass headers in the body. (Closed)

Created:
3 years, 8 months ago by Pete Williamson
Modified:
3 years, 8 months ago
CC:
cbentzel+watch_chromium.org, chili+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dewittj+watch_chromium.org, dimich+watch_chromium.org, David Trainor- moved to gerrit, fgorski+watch_chromium.org, gavinp+prer_chromium.org, jam, petewil+watch_chromium.org, romax+watch_chromium.org, tburkard+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add extra headers argument so we don't pass headers in the body. In the first implementation, we passed extra headers inside the body, a CR comment identified that it would be better to pass them separately, this change separates them out into a different input parameter. BUG=706628 Review-Url: https://codereview.chromium.org/2827503002 Cr-Commit-Position: refs/heads/master@{#465650} Committed: https://chromium.googlesource.com/chromium/src/+/39358c18ce1cc85f8d11144800c88c4146cc6b14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M chrome/browser/android/offline_pages/prerendering_offliner.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/download/mhtml_extra_parts_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/download/mhtml_extra_parts_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M content/public/browser/mhtml_extra_parts.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Pete Williamson
3 years, 8 months ago (2017-04-17 20:23:25 UTC) #6
romax
lgtm
3 years, 8 months ago (2017-04-18 00:29:30 UTC) #8
David Trainor- moved to gerrit
lgtm
3 years, 8 months ago (2017-04-18 22:17:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827503002/1
3 years, 8 months ago (2017-04-18 22:56:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/414398)
3 years, 8 months ago (2017-04-18 23:06:13 UTC) #13
Pete Williamson
+jochen for mhtml_extra_parts.h This is related to https://codereview.chromium.org/2683493002/ which you reviewed about two weeks ago. ...
3 years, 8 months ago (2017-04-18 23:11:14 UTC) #15
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-19 10:15:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827503002/1
3 years, 8 months ago (2017-04-19 17:15:46 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 17:21:57 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/39358c18ce1cc85f8d11144800c8...

Powered by Google App Engine
This is Rietveld 408576698