Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2827443003: Add some tracing to most expensive accessibility functions. (Closed)

Created:
3 years, 8 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some tracing to most expensive accessibility functions. To try it out, enable accessibility first, then visit chrome://tracing, click Record, then check "accessibility". Then do some browsing, go back and stop tracing, then draw a box around some events to see where time is being spent. This will also enable us to add some telemetry benchmarks for accessibility. BUG=712417 Review-Url: https://codereview.chromium.org/2827443003 Cr-Commit-Position: refs/heads/master@{#465249} Committed: https://chromium.googlesource.com/chromium/src/+/04d121c277e84e94e8b56de9a6b09bfb76c17d68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/accessibility/render_accessibility_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dmazzoni
3 years, 8 months ago (2017-04-17 23:50:03 UTC) #2
aboxhall
lgtm Great, looking forward to seeing what this shows up!
3 years, 8 months ago (2017-04-18 05:20:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827443003/1
3 years, 8 months ago (2017-04-18 15:45:06 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 15:49:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04d121c277e84e94e8b56de9a6b0...

Powered by Google App Engine
This is Rietveld 408576698