Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2827443002: Reland [typedarrays] Check detached buffer at start of typed array methods (Closed)

Created:
3 years, 8 months ago by Choongwoo Han
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [typedarrays] Check detached buffer at start of typed array methods - Throw TypeError in ValidateTypedArray, matching JSC, SpiderMonkey and ChakraCore. - Validate typed arrays at start of each typed array prototype methods in src/js/typedarrays.js - Add tests to check detached buffers - Remove an unnecessary parameter of TypedArraySpeciesCreate in src/js/typedarrays.js - Standardize TypedArray.prototype.subarray - Update test262.status to pass detached buffer tests Reland of https://codereview.chromium.org/2778623003 BUG=v8:4648, v8:4665, v8:4953 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2827443002 Cr-Commit-Position: refs/heads/master@{#44878} Committed: https://chromium.googlesource.com/v8/v8/+/9bf2962c14a22317afef4d2107ad790cec1cddab

Patch Set 1 #

Patch Set 2 : add test262.status #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -85 lines) Patch
M src/builtins/builtins-typedarray.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M src/js/typedarray.js View 1 2 18 chunks +26 lines, -26 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M test/mjsunit/es6/typedarray-copywithin.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/es6/typedarray-every.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-fill.js View 2 chunks +14 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-find.js View 2 chunks +15 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-findindex.js View 2 chunks +13 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-foreach.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-indexing.js View 4 chunks +20 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-iteration.js View 4 chunks +17 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-reduce.js View 2 chunks +16 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-reverse.js View 2 chunks +9 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-slice.js View 2 chunks +14 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-sort.js View 2 chunks +7 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-tostring.js View 2 chunks +9 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-353004.js View 1 chunk +8 lines, -8 lines 0 comments Download
M test/mjsunit/regress/regress-4665.js View 2 chunks +7 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 2 3 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 35 (24 generated)
Choongwoo Han
PTAL. Diff is same with https://codereview.chromium.org/2778623003/. The broken layout test is fixed in https://codereview.chromium.org/2810543002/.
3 years, 8 months ago (2017-04-17 11:01:39 UTC) #3
Dan Ehrenberg
lgtm
3 years, 8 months ago (2017-04-17 11:59:14 UTC) #4
Camillo Bruni
lgtm
3 years, 8 months ago (2017-04-18 14:14:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827443002/20001
3 years, 8 months ago (2017-04-25 17:05:02 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/36459) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-04-25 17:06:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827443002/40001
3 years, 8 months ago (2017-04-26 05:50:56 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39820)
3 years, 8 months ago (2017-04-26 05:53:26 UTC) #28
Choongwoo Han
bmeurer@, Can you take a look compiler/*? changes are the same with the previous one: ...
3 years, 8 months ago (2017-04-26 05:55:47 UTC) #29
Benedikt Meurer
LGTM on compiler
3 years, 8 months ago (2017-04-26 05:59:05 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827443002/40001
3 years, 8 months ago (2017-04-26 06:08:59 UTC) #32
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 06:10:25 UTC) #35
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/9bf2962c14a22317afef4d2107ad790cec1...

Powered by Google App Engine
This is Rietveld 408576698