Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2827433005: return initial focused view (Closed)

Created:
3 years, 8 months ago by ftang
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

return initial focused view BUG=608821 Review-Url: https://codereview.chromium.org/2827433005 Cr-Commit-Position: refs/heads/master@{#465075} Committed: https://chromium.googlesource.com/chromium/src/+/daaea2c2c745c2f0983de26d7b812d34622773b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/views/translate/translate_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ftang1
Peter and Rachel: Could you please review this fix. It preset a focus view when ...
3 years, 8 months ago (2017-04-17 21:38:50 UTC) #2
Peter Kasting
LGTM
3 years, 8 months ago (2017-04-17 22:08:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827433005/1
3 years, 8 months ago (2017-04-18 00:21:27 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 00:25:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/daaea2c2c745c2f0983de26d7b81...

Powered by Google App Engine
This is Rietveld 408576698