Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 2827383003: [gm.py] Add support for building mkgrokdump (Closed)

Created:
3 years, 8 months ago by Jakob Kummerow
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[gm.py] Add support for building mkgrokdump Now you can do: "gm.py x64.release mkgrokdump" NOTRY=true Review-Url: https://codereview.chromium.org/2827383003 Cr-Commit-Position: refs/heads/master@{#44756} Committed: https://chromium.googlesource.com/v8/v8/+/0cbe64541307533bb6407dc3e145a21060d1bf00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/dev/gm.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Jakob Kummerow
3 years, 8 months ago (2017-04-20 18:39:49 UTC) #2
Yang
On 2017/04/20 18:39:49, Jakob Kummerow wrote: lgtm
3 years, 8 months ago (2017-04-20 18:43:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827383003/1
3 years, 8 months ago (2017-04-20 19:35:37 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 19:37:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0cbe64541307533bb6407dc3e145a21060d...

Powered by Google App Engine
This is Rietveld 408576698