Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 282733005: Add functions for inspecting SkShader. (Closed)

Created:
6 years, 7 months ago by djsollen
Modified:
6 years, 7 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add functions for inspecting SkShader. Add a function to inspect an SkShader to determine if it is an SkComposeShader. Add a virtual function for determining if an SkShader is a custom shader, which returns a custom set of information. The implementation is in Android, and this function is only defined if SK_BUILD_FOR_ANDROID_FRAMEWORK. BUG=b/10650594 Committed: http://code.google.com/p/skia/source/detail?r=14716

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M include/core/SkComposeShader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 3 chunks +23 lines, -0 lines 2 comments Download
M src/core/SkComposeShader.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
djsollen
rebased clone of https://codereview.chromium.org/272503011/. Since Leon is still out and I can't push the original ...
6 years, 7 months ago (2014-05-13 17:15:40 UTC) #1
reed1
lgtm w/ request for dox (now or later) https://codereview.chromium.org/282733005/diff/1/include/core/SkShader.h File include/core/SkShader.h (right): https://codereview.chromium.org/282733005/diff/1/include/core/SkShader.h#newcode361 include/core/SkShader.h:361: * ...
6 years, 7 months ago (2014-05-13 18:00:23 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 7 months ago (2014-05-13 18:06:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/282733005/1
6 years, 7 months ago (2014-05-13 18:07:13 UTC) #4
djsollen
I'll defer the commenting to Leon. I'll still submit this so we can unblock the ...
6 years, 7 months ago (2014-05-13 18:07:55 UTC) #5
commit-bot: I haz the power
Change committed as 14716
6 years, 7 months ago (2014-05-13 18:14:48 UTC) #6
scroggo
6 years, 7 months ago (2014-05-14 13:51:25 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/282733005/diff/1/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/282733005/diff/1/include/core/SkShader.h#newc...
include/core/SkShader.h:361: *  fill it out with info about the shader.
On 2014/05/13 18:00:24, reed1 wrote:
> ? What is the ownership-rule for the returned pointers? 
> 
> I presume the answer is that they are bare-pointers, and that if the caller
> wants to retain them, he needs to call ref. But no matter what we should
> document this (now or in a later CL).

Uploaded https://codereview.chromium.org/288713002

Powered by Google App Engine
This is Rietveld 408576698